Repository navigation
BUG: Fixes ndarray.fill to accept maximum uint64 value - #5618
Merged
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
I'm not particularly happy with the nesting here, but this case is slightly different from the others in that we're mapping from a single Python type to one of several NumPy types. Suggestions welcome.
Contributor
|
looks good thanks |
johntyree
force-pushed
the
arrfill_ulonglong
branch
from
March 1, 2015 00:14
f8f5d96 to
11dfe93
Compare
Contributor
Author
|
So I think I understood you correctly. There is now a single commit based off of 50afb0f. |
Contributor
|
perfect, that allows us to easily merge it into both branches. |
juliantaylor
added a commit
that referenced
this pull request
Mar 1, 2015
BUG: Fixes ndarray.fill to accept maximum uint64 value
juliantaylor
added a commit
that referenced
this pull request
Mar 1, 2015
BUG: Fixes ndarray.fill to accept maximum uint64 value
Contributor
Author
|
\o/ Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
np.ndarray.fillto attempt to convert touint64if its argument is a Python integer and conversion toint64fails.np.ndarray.fillnow accepts the Python long2**64 - 1as a value. Previously it failed because the value overflows anint64anduint64was not attempted. Constructing the value as auint64manually and then passing it to fill succeeded.Fixes #5612