Conversation
Introduce two new functions, get_data_alignment() and set_data_alignment() which allow setting the guaranteed alignment at runtime.
|
an issue is that with this pointers can't be freed with free anymore, so technically an ABI break. |
|
I noticed that PyDataMem_RENEW() is obviously wrong the base pointer changes alignment. Fixing, but this adds some overhead in cases where the base offset changes. |
Conflicts: numpy/core/src/multiarray/multiarraymodule.c
|
There is a "ready for review" tag, not sure if it helps here... I guess the problem is getting someone to review who knows this better. Anyway, you are right, this is one that could be reactivate, but may need prodding reviewers a bit :). |
|
okay thanks for the summary @seberg. I guess I will tag this and the other pr Ready for Review and revisit this later. |
|
Thanks for this! I will close it, since it is now superseded by gh-17582 and NEP 49 — Data allocation strategies. |
Introduce two new functions, get_data_alignment() and set_data_alignment() which allow
setting the guaranteed alignment at runtime.