Repository navigation
BUG: don't propagate subtypes from np.where - #5105
Merged
Merged
Conversation
Contributor
Author
|
rebased for backport supporting subclasses should be possibly and I'll probably do so, so no tests |
the C implementation cannot preserve subclass attributes, this needs a python wrapper using indexing for subclasses. closes numpygh-5095
juliantaylor
force-pushed
the
where-no-subtype
branch
from
September 23, 2014 19:09
f8a6e63 to
8dd2e47
Compare
juliantaylor
changed the title
Member
|
LGTM pending travis. I've wondered if the iterator works correctly with subtypes. |
charris
added a commit
that referenced
this pull request
Sep 23, 2014
BUG: don't propagate subtypes from np.where
juliantaylor
added a commit
that referenced
this pull request
Sep 23, 2014
BUG: don't propagate subtypes from np.where
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the C implementation cannot preserve subclass attributes, this needs a
python wrapper using indexing for subclasses.
closes gh-5095