Skip to content

Py32 cleanup#44

Closed
rgommers wants to merge 5 commits intonumpy:masterfrom
rgommers:py32-cleanup
Closed

Py32 cleanup#44
rgommers wants to merge 5 commits intonumpy:masterfrom
rgommers:py32-cleanup

Conversation

@rgommers
Copy link
Copy Markdown
Member

@rgommers rgommers commented Mar 1, 2011

Some cleaning of messages from the new and shiny Python 3.2.

There is one ResourceWarning left (see below), I can't see how to fix it.
test_mmap (test_io.TestSaveLoad) ... /Library/Frameworks/Python.framework/Versions/3.2/lib/python3.2/site-packages/numpy/lib/format.py:575: ResourceWarning: unclosed file <_io.BufferedReader name='/var/folders/Uu/UuXfo1NLFae4yyYpsCz-XE+++TI/-Tmp-/tmp37lh1w'>
mode=mode, offset=offset)

@charris
Copy link
Copy Markdown
Member

charris commented Mar 2, 2011

This looks good to me once the stdout bit in numpy/lib/tests/test_regression is removed.

@rgommers
Copy link
Copy Markdown
Member Author

rgommers commented Mar 2, 2011

I guess this is the reason:

In [11]: tmp = np.who({'foo' : np.array(1)})

Name            Shape            Bytes            Type
===========================================================

foo                              4                int32

Upper bound on total bytes  =       4

Keep it after all? It hasn't given any problems so far.

@charris
Copy link
Copy Markdown
Member

charris commented Mar 2, 2011

I think it should be modified to something like:

oldstdout = sys.stdout
try:
... 
except:
...
finally:
    sys.stdout = oldstdout

and perhaps a note added to explain. I'll do that and commit tomorrow if you don't.

I wonder how persistent changes to modules imported locally in functions are?

@rgommers
Copy link
Copy Markdown
Member Author

rgommers commented Mar 2, 2011

I'll try now. Should just be nested try-finally and try-except, otherwise it's not valid Python 2.4 code.

@rgommers
Copy link
Copy Markdown
Member Author

rgommers commented Mar 2, 2011

OK, commited. Thanks Charles.

@njsmith njsmith mentioned this pull request Dec 16, 2012
Closed
@njsmith njsmith mentioned this pull request Jul 3, 2014
Closed
@njsmith njsmith mentioned this pull request May 2, 2016
Closed
@roachlord roachlord mentioned this pull request Feb 18, 2019
Closed
mattip referenced this pull request in mattip/numpy Mar 20, 2019
@bashtage
Merge pull request #44 from bashtage/doc-and-other-small-fixes
fe9cd13 
BUG: Protect gamma generation from 0 input
@siddharth-singh-mindtickle siddharth-singh-mindtickle mentioned this pull request Jul 24, 2019
Closed
fangerer pushed a commit to hpyproject/numpy-hpy that referenced this pull request Jul 7, 2022
@timfel
Pull request numpy#44: Minor fixes
8727279 
Merge in ~STEPAN.SINDELAR_ORACLE.COM/numpy-hpy from tim/graalpython-run to labs-hpy-port

* commit 'cc28777a2d2416a0cffafe4ba203f1e04058b8be':
  remove legacy slots & make types non-legacy if NO_LEGACY is defined
  skip tp_weaklistoffset for graalpython
  remove leftover printf
  port tiny forgotten bit in initumath to hpy
  port remainder of set_typeinfo to hpy
  use convenience enum value for .legacy on dtype types
  fix premature close of h_PyGenericArrType_Type
luyahan pushed a commit to plctlab/numpy that referenced this pull request Apr 25, 2024
@howjmay
Merge pull request numpy#44 from howjmay/vmlal_s8
1bae7df 
feat: Add vmlal_s8
@friedlerido friedlerido mentioned this pull request May 19, 2025
Closed
@vtomole vtomole mentioned this pull request May 28, 2025
Closed
@Sirorezka Sirorezka mentioned this pull request Sep 9, 2025
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rgommers @charris