Skip to content

FIX: make the test_pareto() robust - #425

Closed
certik wants to merge 1 commit into
numpy:masterfrom
certik:fix424
Closed

certik wants to merge 1 commit into
numpy:masterfrom
certik:fix424

Conversation

@certik

@certik certik commented Sep 4, 2012

Copy link
Copy Markdown
Contributor

Fixes #424

The problem was that in 32bit Ubuntu 12.04, one gets the following:

/home/njs/numpy/.tox/py27/local/lib/python2.7/site-packages/numpy/random/tests/test_random.py(363)test_pareto()
-> np.testing.assert_array_almost_equal(actual, desired, decimal=15)
(Pdb) actual[1, 0]
52828779.702948704
(Pdb) desired[1, 0]
52828779.702948518

and the test was comparing the numbers to 1e-14, which obviously failed.
Now we compare them to 1e-6, which works.

Fixes numpy#424

The problem was that in 32bit Ubuntu 12.04, one gets the following:

> /home/njs/numpy/.tox/py27/local/lib/python2.7/site-packages/numpy/random/tests/test_random.py(363)test_pareto()
-> np.testing.assert_array_almost_equal(actual, desired, decimal=15)
(Pdb) actual[1, 0]
52828779.702948704
(Pdb) desired[1, 0]
52828779.702948518

and the test was comparing the numbers to 1e-14, which obviously failed.
Now we compare them to 1e-6, which works.
@travisbot

Copy link
Copy Markdown

This pull request fails (merged 74093c8 into a72ce7e).

@certik

certik commented Sep 4, 2012

Copy link
Copy Markdown
Contributor Author

The failures in this comment seem to be caused by #426 and are unrelated.

@njsmith

njsmith commented Sep 11, 2012

Copy link
Copy Markdown
Member

Closed in favor of #430.

@njsmith njsmith closed this Sep 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mysterious test_pareto failure on Travis

3 participants