BUG: fix hashing of long integers under python3 - #3800

tested on amd64, i386, win32 python 2 and 3
@cgohlke can you test it on win64 with py2 and py3?

All tests pass on Windows with Python 2.7 and 3.3, 32 and 64 bit.

Looks good to me
On 26 Sep 2013 21:50, "Christoph Gohlke" [email protected] wrote:

All tests pass on Windows with Python 2.7 and 3.3, 32 and 64 bit.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3800#issuecomment-25202614
.

Thanks Julian.

I think it should it be backported to 1.8.
What about 1.7? could there be any issues produced by changing the hashing in a stable release?

It's a bug, so probably should go into 1.7 also. What is the difference for python 2?

Only issue I can think of with the stable release thing is that it might
change dict sort order, which sometimes reveals latent bugs in test suites
and things. My feeling is that ensuring correct lookup behavior is more
important.
On 27 Sep 2013 00:30, "Charles Harris" [email protected] wrote:

It's a bug, so probably should go into 1.7 also. What is the difference
for python 2?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3800#issuecomment-25212260
.

python2 is only broken on 32 bit with long long types, e.g. np.int64(-2**32)

#3747 has not been backported to 1.8 and 1.7, this PR depends on it.

nevermind, I forgot to pull on the maintainance branch