Repository navigation
Fix issue #3743: Hash changed signature in Python 3.3 - #3747
Merged
Merged
Conversation
As of Python 3.2 hash values are of type Py_hash_t. Previous versions use C long.
Member
There was a problem hiding this comment.
Guess this is OK. IIRC, npy_intp is defined as Py_ssize_t for later Python.
Member
|
LGTM. Thanks Christolph. |
charris
added a commit
that referenced
this pull request
Sep 14, 2013
Fix issue #3743: Hash changed signature in Python 3.3
Member
|
Should I do the backports? |
Member
|
Done. Thanks for fixing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Python 3.2 hash values are of type Py_hash_t. Previous versions use C long.
The changes should only affect win-amd64-py3.x, where
sizeof(Py_hash_t) != sizeof(long).This fixes issue #3743. All tests pass on win-amd64-py3.3, win-amd64-py2.7, and win32-py2.7.
Needs backport to 1.8 and 1.7.