Skip to content

ENH: copy ndarrays if they are encountered in setArrayFromSequence - #3696

Merged
njsmith merged 1 commit into
numpy:masterfrom
juliantaylor:copy-array-create
Sep 9, 2013
Merged

njsmith merged 1 commit into
numpy:masterfrom
juliantaylor:copy-array-create

Conversation

@juliantaylor

Copy link
Copy Markdown
Contributor

By avoiding the elementwise copy array([a,b,c]) is now as
fast as vstack([a,b,c])

By avoiding the elementwise copy array([a,b,c]) is now as
fast as vstack([a,b,c])
@juliantaylor

Copy link
Copy Markdown
Contributor Author

almost solves the performance issue Graeme Belt reported on the list. (3.4s -> 0.55s)
http://mail.scipy.org/pipermail/numpy-discussion/2013-September/067607.html

the rest is inefficient short circuit reduction for multidimensional arrays.

@njsmith

njsmith commented Sep 7, 2013

Copy link
Copy Markdown
Member

Looks good to me
On 7 Sep 2013 12:24, "Julian Taylor" [email protected] wrote:

By avoiding the elementwise copy array([a,b,c]) is now as

fast as vstack([a,b,c])

You can merge this Pull Request by running

git pull https://github.com/juliantaylor/numpy copy-array-create

Or view, comment on, or merge it at:

#3696
Commit Summary

  • ENH: copy ndarrays if they are encountered in setArrayFromSequence

File Changes

Patch Links:

njsmith added a commit that referenced this pull request Sep 9, 2013
ENH: copy ndarrays if they are encountered in setArrayFromSequence
@njsmith
njsmith merged commit 72d2382 into numpy:master Sep 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants