Repository navigation
Conversation
Member
Author
Merging that is blocked on python/pythoncapi-compat#187. IMO we should fix this right now because the current code is wrong. Then when the compat headers grow a definition this will just work. |
Member
Author
|
Ugh except the tests are failing... |
Member
Author
|
Closing in favor of #32871. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
My clanker found this while reviewing #32213. That PR adds tests that trigger a refcounting bug because of this.
This extension is only used in tests and the real minimummaximum implementation does this correctly.
AI Disclosure
An AI model noticed the issue.