Repository navigation
Conversation
Member
|
I think this is probably fine? It needs a release note though. |
Contributor
Author
will add release note |
Member
|
I milestoned and marked this to be reviewed at a triage meeting. I'm not sure if the mailing list was ever pinged for this, but API changes should generally follow a mailing list discussion about it. Otherwise this looks fine to me and I think it does make sense to simply pass the argument to |
Contributor
Author
|
Yep. It does make sense. It seems the next triage meeting will be next week. I might able to attend the meeting too. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR is continuing this closed PR #22429. Solving issue #22427 and #25640.
Before
import numpy as np
After adding dtype argument
I'm interested working on this PR because I did solved array type issue previously (#32555) and want to keep working on open source project. This will help me and other users have exact type for their array when using append().
I'm aware there are lot of discussion in other PR about
append()method. My current implementation just continuing the closed unmerged PR. I'm open with new suggestion how the newappend()should be written for future release (even totally different approach).AI Disclosure
I use Opencode to understand the repository and create initial draft. I rewrite the code and test it manually.