Repository navigation
BUG: fix visibility annotations for functions in StringDType implementation - #32371
Merged
Merged
Conversation
ngoldbaum
added
00 - Bug
09 - Backport-Candidate
ngoldbaum
commented
Aug 20, 2026
| stringdtype_finalize_descr(PyArray_Descr *dtype); | ||
|
|
||
| NPY_NO_EXPORT int | ||
| _eq_comparison(int scoerce, int ocoerce, PyObject *sna, PyObject *ona); |
Member
Author
There was a problem hiding this comment.
this is only used in dtype.c now so we can remove it from the header
Member
|
Did someone say annotations!? Oh... It's those kinds of annotations :P |
charris
approved these changes
Aug 20, 2026
Member
|
Thanks Nathan. |
charris
pushed a commit
that referenced
this pull request
Aug 21, 2026
charris
added a commit
that referenced
this pull request
Aug 21, 2026
BUG: fix visibility annotations for functions in StringDType implementation (#32371)
ngoldbaum
added a commit
to ngoldbaum/numpy
that referenced
this pull request
Sep 8, 2026
ngoldbaum
added a commit
to ngoldbaum/numpy
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Adds missing
staticorNPY_NO_EXPORTvisibility annotations for several functions in the StringDType implementation.Noticed while working on the ByteStringDType impelementation.
AI Disclosure
No AI use.