Repository navigation
ENH: Port _multiarray_tests to the Limited API - #32251
Merged
Merged
Conversation
Member
Author
|
I think this PR is good to be ready for review, but I would like to re-review it myself first! |
prathamhole14
marked this pull request as ready for review
August 16, 2026 06:14
ngoldbaum
reviewed
Aug 18, 2026
ngoldbaum
left a comment
ngoldbaum
left a comment
Member
There was a problem hiding this comment.
This looks good but I noticed some issues in surrounding code and have one substantive suggestion.
6 of 7 tasks
Member
Author
|
This PR is ready! |
Member
|
There are merge conflicts. |
mattip
reviewed
Sep 6, 2026
| Py_SETREF(result, PyImport_Import(result)); | ||
| PyObject *module = PyImport_Import(result); | ||
| Py_DECREF(result); | ||
| result = module; |
Member
There was a problem hiding this comment.
Why this change? Isn't the macro available on the limited API?
Member
Author
There was a problem hiding this comment.
It is not Py_SETREF is only in cpython/object.h which object.h includes under #ifndef Py_LIMITED_API. Compiling it with -DPy_LIMITED_API=0x030d0000 gives implicit declaration of function 'Py_SETREF'.
Edit: see python/cpython#99574
Member
|
Thanks @prathamhole14 |
Member
|
Also see capi-workgroup/decisions#110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Related to: #31913
AI Disclosure
In understanding things, and finding places where changes are required and reviewing the changes.