Repository navigation
ENH: Add limited API support for _struct_ufunc_tests module - #32210
Merged
ngoldbaum merged 5 commits intoAug 12, 2026
Merged
Conversation
Member
Author
|
I think the failing test is unrelated, this PR is ready for review! |
ngoldbaum
reviewed
Aug 7, 2026
Comment on lines
+6
to
+12
| /* Build as a downstream module: the internal `PyArray_DTypeMeta` is built on | ||
| * `PyHeapTypeObject`, which is not in the limited API. `NPY_TARGET_VERSION` | ||
| * keeps the API target that `NPY_INTERNAL_BUILD` implied. */ | ||
| #if defined(NPY_INTERNAL_BUILD) | ||
| #undef NPY_INTERNAL_BUILD | ||
| #endif | ||
| #define NPY_TARGET_VERSION NPY_API_VERSION |
Member
There was a problem hiding this comment.
I think this is OK? But I'd like it if another C API expert could confirm.
These tests are all supposed to check if we're breaking external C API users, so you could even argue this is a more correct way to do it.
ngoldbaum
approved these changes
Aug 7, 2026
Member
|
Merging the other PR introduced a conflict - I'll merge this after you clear it. |
Member
|
Thanks @prathamhole14 |
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Related to: #31913
AI Disclosure
For the comment.