CI: Update CI to validate Limited API in debug job builds by prathamhole14 · Pull Request #32130 · numpy/numpy

prathamhole14 · 2026-07-28T12:16:58Z

PR summary

JOB: Check that the extension modules ported to the Limited C API were built against it.

To check if each ported module has its own abi3.so file, in this CI each ported module is to be added in the list for m in _pocketfft_umath; do, I will do it manually when I add the limited_api for each extension module.

Note: I think the regex would unnecessarily complicate things for temporary stage that's why I am going with manually adding approach
Once everything is shifted this can be easily automated as we will use limited-api = true in global meson build or complete all extended module checks.

Reference: #31913 (comment) and #31913 (comment)

Updated: The debug interpreter doesn't produce .abi3.so named exenstion files at all, because it means this job proves the ported modules compile under Py_LIMITED_API so therefore they must have produced .abi3.so files.

AI Disclosure

For bash syntax

ngoldbaum · 2026-07-29T14:50:39Z

I will do it manually when I add the limited_api for each extension module.

Can we get explicit checks for this as part of a CI job?

prathamhole14 · 2026-07-29T16:16:48Z

Three ways it fails the CI job:

a listed module wasn't built at all
a listed module was built without the flag (the allow_limited_api option silently didn't apply)
a module was built with the flag but isn't listed (someone ported one and forgot the list)

ngoldbaum

Overall looks good, I spotted a couple issues below though.

@rgommers @andyfaff can I get one of you to look at this as the local CI experts?

rgommers · 2026-07-31T16:03:20Z

Question @prathamhole14: why do we need this script at all? I was just expecting a -Dpython.allow_limited_api=true addition, so the extension module becomes .abi3 and that gets exercised when regular CI runs to ensure it's all functional. When you proposed adding CI you pointed at PyWavelets/pywt#828 as a reference, and that doesn't do anything like this script.

prathamhole14 · 2026-07-31T17:03:20Z

Question @prathamhole14: why do we need this script at all? I was just expecting a -Dpython.allow_limited_api=true addition, so the extension module becomes .abi3 and that gets exercised when regular CI runs to ensure it's all functional. When you proposed adding CI you pointed at PyWavelets/pywt#828 as a reference, and that doesn't do anything like this script.

Fair, dropping the script. I only wanted to catch the flag silently becoming a no-op, and a grep for Py_LIMITED_API in build/*/compile_commands.json covers that in one line. Happy to leave even that out if you'd rather just have the flag.

rgommers · 2026-07-31T18:46:09Z

I'd prefer just the flag, yes. That should suffice, so let's try to keep it as clean as possible.

andyfaff · 2026-07-31T21:07:38Z

Perhaps I'm missing something. Why don't we just use the abi3audit package? Make a wheel as part of the job and audit that.

On looking in more detail the PR seems like a ratchet to ensure that extension modules that have been ported don't slide back. It may be possible to just use abi3audit against each known extension.

rgommers · 2026-08-01T19:03:39Z

Why don't we just use the abi3audit package? Make a wheel as part of the job and audit that.

That's indeed a good idea, but only after all of numpy builds as an abi3 wheel. Right now only part of the extension modules build.

On looking in more detail the PR seems like a ratchet to ensure that extension modules that have been ported don't slide back.

They won't slide back, no special check is needed - if something is used that isn't in the Limited API, it will cause a build failure as soon as -Dpython.allow_limited_api=true is called.

andyfaff · 2026-08-01T21:42:12Z

That's indeed a good idea, but only after all of numpy builds as an abi3 wheel. Right now only part of the extension modules build.

One can run the tool against individual extension modules. e.g.

e.g.

# after building with:
# spin build -- -Dbuildtype=debug -Dallow-noblas=true -Dpython.allow_limited_api=true

(dev3) nelly:random andrew$ abi3audit --assume-minimum-abi3 3.11 _sfc64.cpython-314-darwin.so -S -v
[07:50:25] 👎 : _sfc64.cpython-314-darwin.so has non-ABI3 symbols                                                                                    
           👎 : _sfc64.cpython-314-darwin.so uses the Python 3.15 ABI, but is tagged for the Python 3.11 ABI                                         
           ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓                                                                                   
           ┃ Symbol                                   ┃ Version  ┃                                                                                   
           ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩                                                                                   
           │ PyUnstable_Object_EnableDeferredRefcount │ not ABI3 │                                                                                   
           │ PyCode_NewEmpty                          │ not ABI3 │                                                                                   
           │ PyDict_SetDefault                        │ not ABI3 │                                                                                   
           │ PyUnicode_AsUTF8                         │ not ABI3 │                                                                                   
           │ PyFrame_New                              │ not ABI3 │                                                                                   
           │ PyObject_CallFinalizerFromDealloc        │ not ABI3 │                                                                                   
           │ PyObject_ClearManagedDict                │ not ABI3 │                                                                                   
           │ PyMethod_New                             │ not ABI3 │                                                                                   
           │ PyMethod_Type                            │ not ABI3 │                                                                                   
           │ PyObject_VectorcallDict                  │ not ABI3 │                                                                                   
           │ _PyType_Lookup                           │ not ABI3 │                                                                                   
           │ PyObject_VisitManagedDict                │ not ABI3 │                                                                                   
           │ PyDict_Pop                               │ not ABI3 │                                                                                   
           │ PyUnstable_Code_NewWithPosOnlyArgs       │ not ABI3 │                                                                                   
           │ PyThreadState_GetUnchecked               │ not ABI3 │                                                                                   
           │ _PyDict_GetItem_KnownHash                │ not ABI3 │                                                                                   
           │ PyDict_SetDefaultRef                     │ 3.15     │                                                                                   
           │ PyObject_Vectorcall                      │ 3.12     │                                                                                   
           │ PyDict_GetItemRef                        │ 3.13     │                                                                                   
           │ PyDict_GetItemStringRef                  │ 3.13     │                                                                                   
           │ PyObject_GetOptionalAttr                 │ 3.13     │                                                                                   
           │ PyType_FromMetaclass                     │ 3.12     │                                                                                   
           │ PyImport_AddModuleRef                    │ 3.13     │                                                                                   
           │ PyObject_HasAttrWithError                │ 3.13     │                                                                                   
           │ PyObject_VectorcallMethod                │ 3.12     │                                                                                   
           └──────────────────────────────────────────┴──────────┘                                                                                   
           💁 _sfc64.cpython-314-darwin.so: 1 extensions scanned; 1 ABI version mismatches and 16 ABI violations found

rgommers · 2026-08-04T06:09:00Z

One can run the tool against individual extension modules. e.g.

Thanks. I knew that, my argument was more that it's essentially free once we have a wheel, and we don't want to complicate CI for this now. This whole exercise for seeing how far moving to the limited API is experimental, it might run into a hard blocker, or yield performance-related regressions that are of a size we care about. Until we figure that out, we want to merge only the minimal diffs (same reason as not merging the separate script that was in this PR). This kind of auditing is easy enough to do locally, and isn't on the critical path right now.

rgommers

Let's give this a go, thanks @prathamhole14 and reviewers.

ngoldbaum mentioned this pull request Jul 29, 2026

ENH: Port numpy.random extension modules to the Limited API and update limited_api to 3.13 #32112

Merged

prathamhole14 marked this pull request as draft July 29, 2026 16:53

prathamhole14 force-pushed the limited_api_ci branch from cd99c16 to d89527b Compare July 29, 2026 17:26

prathamhole14 marked this pull request as ready for review July 29, 2026 19:06

ngoldbaum reviewed Jul 31, 2026

View reviewed changes

Comment thread tools/ci/check_limited_api.py Resolved

Comment thread tools/ci/check_limited_api.py Resolved

Comment thread tools/ci/check_limited_api.py Resolved

CI: build against the Limited API in the debug job

a98f8e7

prathamhole14 force-pushed the limited_api_ci branch from d89527b to a98f8e7 Compare August 3, 2026 14:11

rgommers approved these changes Aug 4, 2026

View reviewed changes

rgommers merged commit 702a259 into numpy:main Aug 4, 2026
89 checks passed

rgommers added the component: CI label Aug 4, 2026

rgommers added this to the 2.6.0 Release milestone Aug 4, 2026

prathamhole14 deleted the limited_api_ci branch August 4, 2026 06:33

prathamhole14 mentioned this pull request Aug 28, 2026

Tracking Issue: Adoption of CPython limited API #31913

Open

6 of 7 tasks

Conversation

prathamhole14 commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR summary

AI Disclosure

Uh oh!

ngoldbaum commented Jul 29, 2026

Uh oh!

prathamhole14 commented Jul 29, 2026

Uh oh!

ngoldbaum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rgommers commented Jul 31, 2026

Uh oh!

prathamhole14 commented Jul 31, 2026

Uh oh!

rgommers commented Jul 31, 2026

Uh oh!

andyfaff commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rgommers commented Aug 1, 2026

Uh oh!

andyfaff commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rgommers commented Aug 4, 2026

Uh oh!

rgommers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

prathamhole14 commented Jul 28, 2026 •

edited

Loading

andyfaff commented Jul 31, 2026 •

edited

Loading

andyfaff commented Aug 1, 2026 •

edited

Loading