Skip to content

BUG: centralized helper for output coerce and na_object in stringdtype operations (#31884) - #31952

Merged
charris merged 1 commit into
numpy:maintenance/2.5.xfrom
charris:backport-31884
Jul 10, 2026
Merged

BUG: centralized helper for output coerce and na_object in stringdtype operations (#31884)#31952
charris merged 1 commit into
numpy:maintenance/2.5.xfrom
charris:backport-31884

Conversation

@charris

@charris charris commented Jul 10, 2026

Copy link
Copy Markdown
Member

Backport of #31884.

PR summary

Related to #31825 but issuing it as a separate PR because the two changes don't overlap at all.

We currently have custom logic for determining the correct na_object and coerce value when operations mix StringDType instances. In some cases this can even lead to crashes. The following script segfaults for me because the na_object in the fill character array is not being handled correctly.

Python 3.14.5 (main, May 22 2026, 08:10:06) [Clang 21.0.0 (clang-2100.0.123.102)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import numpy as np
>>> from numpy.dtypes import StringDType
>>> print(np.__version__)
2.5.1
>>> arr = np.array(["a"], dtype="T")
>>> fill = np.array("*", dtype=StringDType(na_object="*"))
>>> print(np.strings.center(arr, 5, fill))
[1]    87011 segmentation fault  python

This centralizes the logic for handling the na_object and coerce argument in ufunc loops and in the comparison machinery into one set of shared helpers.

Also adds tests for this behavior, including the case that leads to a crash above.

First time committer introduction

AI Disclosure

I found this issue using an AI model. I also used an AI model to help with the tests and the approach for the fix.

@charris charris added this to the 2.5.2 release milestone Jul 10, 2026
@charris charris added 00 - Bug 08 - Backport Used to tag backport PRs component: numpy.strings String dtypes and functions labels Jul 10, 2026
@charris
charris merged commit bb246e0 into numpy:maintenance/2.5.x Jul 10, 2026
85 checks passed
@charris
charris deleted the backport-31884 branch July 10, 2026 23:36
736-c41-2c1-e464fc974 pushed a commit to Swiss-Armed-Forces/Loom that referenced this pull request Aug 16, 2026
open-source Pipeline Loom MR Pipeline Trigger @736-c41-2c1-e464fc974
chore(deps): update backend dependencies (patch)
4b44427 
This MR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
| [numpy](https://github.com/numpy/numpy) ([changelog](https://numpy.org/doc/stable/release)) | dependencies | patch | `2.5.0` → `2.5.2` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/numpy/numpy/badge)](https://securityscorecards.dev/viewer/?uri=github.com/numpy/numpy) |
| [uvicorn](https://github.com/Kludex/uvicorn) ([changelog](https://uvicorn.dev/release-notes)) | dependencies | patch | `0.52.1` → `0.52.3` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/Kludex/uvicorn/badge)](https://securityscorecards.dev/viewer/?uri=github.com/Kludex/uvicorn) |

---

### Release Notes

<details>
<summary>numpy/numpy (numpy)</summary>

### [`v2.5.2`](https://github.com/numpy/numpy/releases/tag/v2.5.2): (Aug 9, 2026)

[Compare Source](numpy/numpy@v2.5.1...v2.5.2)

### NumPy 2.5.2 Release Notes

The NumPy 2.5.2 is a patch release that fixes bugs discovered after the 2.5.1
release. The big news is that it includes wheels for the newly released
Python 3.15.0rc1.

This release supports Python versions 3.12-3.15

#### C API changes

##### `PyArray_StringDTypeObject` is opaque under the abi3t stable ABI

The `PyArray_StringDTypeObject` was accidentally exposed in NumPy
2.5 when targeting the free-threading-compatible stable ABI
(`Py_TARGET_ABI3T`). `PyArray_StringDTypeObject` is now an opaque
struct: extensions compiled that way cannot access its fields, since
the struct layout depends on the size of the object header. Any code
that accessed `PyArray_StringDTypeObject` fields in an abi3t build
would have crashed, so we are making this API change in a bugfix
release.

The `NpyString` allocator API remains usable by passing the
descriptor object pointer, e.g.
`NpyString_acquire_allocator((PyArray_StringDTypeObject *)descr)`.

([gh-31771](numpy/numpy#31771))

#### Contributors

A total of 16 people contributed to this release. People with a "+" by their
names contributed a patch for the first time.

- Abhijeetsingh Meena +
- Charalampos Stratakis
- Charles Harris
- Chris Ninham +
- David Woods
- Geonho +
- Gopu Yeshwanth Reddy +
- Iason Krommydas
- Ijtihed Kilani
- Jelle Zijlstra +
- Joren Hammudoglu
- Kumar Aditya
- Mike Boyle
- Nathan Goldbaum
- Raghuveer Devulapalli
- Sebastian Berg

#### Pull requests merged

A total of 28 pull requests were merged for this release.

- [#&#8203;31864](numpy/numpy#31864): MAINT: Prepare 2.5.x for further development
- [#&#8203;31889](numpy/numpy#31889): TYP: Backport multiple static typing fixes 1.
- [#&#8203;31900](numpy/numpy#31900): TST: add tests for stable ABI numpy extensions ([#&#8203;31822](numpy/numpy#31822))
- [#&#8203;31901](numpy/numpy#31901): BUG: fix `StringDType` coerce flag in binary ufunc promotion...
- [#&#8203;31902](numpy/numpy#31902): BLD: fix meson deprecation warnings ([#&#8203;31892](numpy/numpy#31892))
- [#&#8203;31921](numpy/numpy#31921): TYP: Backport multiple typing fixes 2.
- [#&#8203;31947](numpy/numpy#31947): MAINT: Update x86-simd-sort subproject ([`5adb334`](numpy/numpy@5adb334) → [`fa944ef`](numpy/numpy@fa944ef)) ([#&#8203;31908](numpy/numpy#31908))
- [#&#8203;31949](numpy/numpy#31949): BUG: fix crash on 32 bit systems using abi3t ([#&#8203;31771](numpy/numpy#31771))
- [#&#8203;31950](numpy/numpy#31950): MNT: remove some obsolete string to bool workarounds ([#&#8203;31859](numpy/numpy#31859))
- [#&#8203;31952](numpy/numpy#31952): BUG: centralized helper for output coerce and na\_object in stringdtype...
- [#&#8203;31953](numpy/numpy#31953): BUG: fix CPU feature env diagnostic buffer overruns ([#&#8203;31905](numpy/numpy#31905))
- [#&#8203;31954](numpy/numpy#31954): BUG: restore ndarray.conjugate() for legacy user-defined dtypes...
- [#&#8203;31955](numpy/numpy#31955): TYP: Avoid shadowed dtype annotations
- [#&#8203;32077](numpy/numpy#32077): MAINT: Update verdored-meson/meson to match main.
- [#&#8203;32114](numpy/numpy#32114): BUG: fix refcount leak on overlapping copyto with where=False
- [#&#8203;32115](numpy/numpy#32115): BUG: fix swallowed cast error in fancy indexing assignment ([#&#8203;31975](numpy/numpy#31975))
- [#&#8203;32116](numpy/numpy#32116): BUG: Fix buffered iterator stride after removing multi-index
- [#&#8203;32117](numpy/numpy#32117): BUG: fix `np.fromiter` corruption when reusing a `StringDType`...
- [#&#8203;32119](numpy/numpy#32119): BUG: add a special case for StringDType in np.isdtype ([#&#8203;32030](numpy/numpy#32030))
- [#&#8203;32121](numpy/numpy#32121): BUG: reference leak in `simd_sequence_from_iterable` ([#&#8203;32038](numpy/numpy#32038))
- [#&#8203;32122](numpy/numpy#32122): BUG: ensure lock is held when accessing or writing to RNG state...
- [#&#8203;32123](numpy/numpy#32123): BUG: fully reset cached RNG state for non-MT19937 RNGs ([#&#8203;32062](numpy/numpy#32062))
- [#&#8203;32135](numpy/numpy#32135): TYP: type capabilities max dimensions
- [#&#8203;32158](numpy/numpy#32158): BUG: avoid possible stack overflow in arraydescr\_dealloc ([#&#8203;32133](numpy/numpy#32133))
- [#&#8203;32206](numpy/numpy#32206): MAINT: Update cibuildwheel to v4.2.0
- [#&#8203;32214](numpy/numpy#32214): MAINT: Skip limited\_api tests on some platforms.
- [#&#8203;32220](numpy/numpy#32220): TYP: `isclose` shape-typing fix for 2d array-likes ([#&#8203;32205](numpy/numpy#32205))
- [#&#8203;32221](numpy/numpy#32221): BUG: avoid segfaults when legacy copyswap slot is not defined...

### [`v2.5.1`](https://github.com/numpy/numpy/releases/tag/v2.5.1): (July 4, 2026)

[Compare Source](numpy/numpy@v2.5.0...v2.5.1)

### NumPy 2.5.1 Release Notes

The NumPy 2.5.1 is a patch release that fixes bugs discovered after the 2.5.0
release. The most noticeable is the fix is to the numpy datetime cython API
which should allow downstream to support NumPy versions older than 2.5.
Preparation for Python 3.15 continues along with typing improvements.

This release supports Python versions 3.12-3.14

#### Changes

- The minimum supported GCC version has been updated from 9.3.0 to 10.3.0

  ([gh-31843](numpy/numpy#31843))

#### Contributors

A total of 10 people contributed to this release. People with a "+" by their
names contributed a patch for the first time.

- Adhyan Gupta +
- Ankit Ahlawat
- Charles Harris
- Iason Krommydas
- Joren Hammudoglu
- Kumar Aditya
- Nathan Goldbaum
- Sebastian Berg
- Ties Jan Hefting +
- Vineet Kumar

#### Pull requests merged

A total of 20 pull requests were merged for this release.

- [#&#8203;31707](numpy/numpy#31707): MAINT: Prepare 2.5.x for further development
- [#&#8203;31721](numpy/numpy#31721): CI: fix new `cython-lint` errors ([#&#8203;31711](numpy/numpy#31711))
- [#&#8203;31723](numpy/numpy#31723): MAINT: Update meson to match main
- [#&#8203;31729](numpy/numpy#31729): TST: use setup-sde instead of curl to get SDE binaries ([#&#8203;31727](numpy/numpy#31727))
- [#&#8203;31829](numpy/numpy#31829): BUG: Relax finfo to be easier accessible for all user dtypes...
- [#&#8203;31831](numpy/numpy#31831): TYP: Fix `flatiter.__next__` return type for `object_` and...
- [#&#8203;31832](numpy/numpy#31832): BUG: avoid deadlocks using NpyString API ([#&#8203;31682](numpy/numpy#31682))
- [#&#8203;31833](numpy/numpy#31833): BUG: fix out array leak in reduceat and accumulate when dtype...
- [#&#8203;31835](numpy/numpy#31835): BUG: fix numpy datetime cython APIs to be compatible with older...
- [#&#8203;31836](numpy/numpy#31836): TYP: Fix incorrect dtype inference of `asarray([])` ([#&#8203;31732](numpy/numpy#31732))
- [#&#8203;31837](numpy/numpy#31837): TYP: Fix `np.ma.masked_array` 2.5.0 regression
- [#&#8203;31838](numpy/numpy#31838): FIX: Refactor error handling in array\_setstate to prevent typecode...
- [#&#8203;31839](numpy/numpy#31839): TST: xfail multithreaded BLAS test more generously
- [#&#8203;31840](numpy/numpy#31840): MAINT: Rename subroutine for crackfortran tests
- [#&#8203;31842](numpy/numpy#31842): BUG: fix leak in reductions when a ufunc override errors or is...
- [#&#8203;31849](numpy/numpy#31849): BLD: set minimum required gcc version to 10.3 ([#&#8203;31843](numpy/numpy#31843))
- [#&#8203;31855](numpy/numpy#31855): CI: fix hangs on MacOS ASan CI ([#&#8203;31853](numpy/numpy#31853))
- [#&#8203;31856](numpy/numpy#31856): BUG: fix several bugs in StringDType operations ([#&#8203;31846](numpy/numpy#31846))
- [#&#8203;31857](numpy/numpy#31857): BUG: Fix segfault in MT19937 by preventing recursive seed lists...
- [#&#8203;31858](numpy/numpy#31858): BUG: Fix signed integer overflow in datetime.c ([#&#8203;31688](numpy/numpy#31688))

</details>

<details>
<summary>Kludex/uvicorn (uvicorn)</summary>

### [`v0.52.3`](https://github.com/Kludex/uvicorn/releases/tag/0.52.3): Version 0.52.3

[Compare Source](Kludex/uvicorn@0.52.2...0.52.3)

##### Changed

- Update `zttp` to 0.0.24 and use its combined receive path, improving HTTP/1.1 request parsing performance ([#&#8203;3067](Kludex/uvicorn#3067))

**Full Changelog**: <Kludex/uvicorn@0.52.2...0.52.3>

### [`v0.52.2`](https://github.com/Kludex/uvicorn/releases/tag/0.52.2): Version 0.52.2

[Compare Source](Kludex/uvicorn@0.52.1...0.52.2)

##### Fixed

- Update `zttp` to 0.0.22, fixing bodyless request receives and improving HTTP/1 request parsing performance ([#&#8203;3063](Kludex/uvicorn#3063))

**Full Changelog**: <Kludex/uvicorn@0.52.1...0.52.2>

</details>

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTEuMyIsInVwZGF0ZWRJblZlciI6IjQ0LjMwLjQiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsInJlbm92YXRlIl19-->

See merge request swiss-armed-forces/cyber-command/cea/loom!639

Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

00 - Bug 08 - Backport Used to tag backport PRs component: numpy.strings String dtypes and functions

Projects

None yet

Milestone

2.5.2 release

Development

Successfully merging this pull request may close these issues.

2 participants

@charris @ngoldbaum