Skip to content

TYP: 2nd histogramdd return type should be list, not tuple - #31916

Merged
charris merged 1 commit into
numpy:mainfrom
jorenham:typing/histogramdd.1-list
Jul 8, 2026
Merged

charris merged 1 commit into
numpy:mainfrom
jorenham:typing/histogramdd.1-list

Conversation

@jorenham

@jorenham jorenham commented Jul 8, 2026

Copy link
Copy Markdown
Member

because

In [1]: tuple(map(type, np.histogramdd([1,2,3])))
Out[1]: (numpy.ndarray, list)

Fully written by me (a human); bug found by Claude Fable 5 (here's the full (second) audit for those interested).

(even more stub fixes on the way)

@jorenham jorenham added 09 - Backport-Candidate PRs tagged should be backported 41 - Static typing labels Jul 8, 2026
@charris
charris merged commit c1035e2 into numpy:main Jul 8, 2026
14 checks passed
@charris

charris commented Jul 8, 2026

Copy link
Copy Markdown
Member

Thanks Joren.

@jorenham
jorenham deleted the typing/histogramdd.1-list branch July 8, 2026 12:41
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants