Skip to content

TYP: fix tri{l,u} shape-typing for 1d input - #31886

Merged
charris merged 1 commit into
numpy:mainfrom
jorenham:typing/tril-triu-2d+
Jul 6, 2026
Merged

charris merged 1 commit into
numpy:mainfrom
jorenham:typing/tril-triu-2d+

Conversation

@jorenham

@jorenham jorenham commented Jul 6, 2026

Copy link
Copy Markdown
Member

np.tril and np.triu return a 2d array for 1d input at runtime, but the stubs returned a 1d array in this case.


Fully written by me (a human, I think); bug found by Claude Fable 5 (high) (here's the full audit for those interested).

@jorenham jorenham added 09 - Backport-Candidate PRs tagged should be backported 41 - Static typing labels Jul 6, 2026
@charris
charris merged commit 742d401 into numpy:main Jul 6, 2026
14 checks passed
@charris

charris commented Jul 6, 2026

Copy link
Copy Markdown
Member

Thanks Joren.

@jorenham
jorenham deleted the typing/tril-triu-2d+ branch July 6, 2026 21:28
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jul 6, 2026
charris pushed a commit that referenced this pull request Jul 6, 2026
MaanasArora pushed a commit to MaanasArora/numpy that referenced this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants