Repository navigation
BUG: centralized helper for output coerce and na_object in stringdtype operations - #31884
Merged
Merged
Conversation
ngoldbaum
force-pushed
the
nan-coerce-consistency
branch
from
July 6, 2026 19:57
0ce76e4 to
2f6a487
Compare
Member
Author
Member
Author
|
@Ethan0456 you just put in a PR for a similar issue. Maybe you want to take a look at this? |
Contributor
|
@ngoldbaum LGTM! thanks for the clear repro. I reproduced the |
Member
|
Thanks Nathan. |
charris
pushed a commit
that referenced
this pull request
Jul 10, 2026
charris
added a commit
that referenced
this pull request
Jul 10, 2026
BUG: centralized helper for output coerce and na_object in stringdtype operations (#31884)
ngoldbaum
added a commit
to ngoldbaum/numpy
that referenced
this pull request
Aug 4, 2026
…e operations (numpy#31884) (cherry picked from commit e4b464d)
ngoldbaum
added a commit
to ngoldbaum/numpy
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Related to #31825 but issuing it as a separate PR because the two changes don't overlap at all.
We currently have custom logic for determining the correct
na_objectandcoercevalue when operations mixStringDTypeinstances. In some cases this can even lead to crashes. The following script segfaults for me because thena_objectin the fill character array is not being handled correctly.This centralizes the logic for handling the
na_objectandcoerceargument in ufunc loops and in the comparison machinery into one set of shared helpers.Also adds tests for this behavior, including the case that leads to a crash above.
First time committer introduction
AI Disclosure
I found this issue using an AI model. I also used an AI model to help with the tests and the approach for the fix.