Repository navigation
TYP: fix random.RandomState.get_state conflicting overloads - #31881
Merged
Merged
Conversation
jorenham
added
component: numpy.random
09 - Backport-Candidate
jorenham
force-pushed
the
typing/random.RandomState.get_state
branch
from
July 6, 2026 18:10
bcd8fde to
2306307
Compare
Member
|
Thanks Joren. |
charris
pushed a commit
that referenced
this pull request
Jul 6, 2026
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
random.RandomState.get_state()(i.e. without passinglegacy) incorrectly resulted in adict[str, Any]output type because the first overload incorrectly has alegacy: Literal[False] = Falsedefault set. At runtime, it defaults toTrue.According to Claude Fable 5 backporting this is a good idea because "state pickling is a common use of this API". I never use this API myself, so i'm not sure if that's true. So if you think it isn't, then just remove the backport-canditate label.
Fully written by me (a human, I think); bug found by Claude Fable 5 (high) (here's the full audit for those interested).