Repository navigation
TYP: fix int promotion for *sum and *prod - #31876
Merged
Merged
Conversation
jorenham
added
09 - Backport-Candidate
|
Diff from mypy_primer, showing the effect of this PR on type check results on a corpus of open source code: jax (https://github.com/google/jax)
- jax/_src/numpy/hijax.py:269: error: Incompatible types in assignment (expression has type "tuple[Any, ...]", variable has type "ndarray[tuple[Any, ...], dtype[float64]]") [assignment]
+ jax/_src/numpy/hijax.py:269: error: Incompatible types in assignment (expression has type "tuple[Any, ...]", variable has type "ndarray[tuple[Any, ...], dtype[signedinteger[Any]]]") [assignment]
|
charris
pushed a commit
that referenced
this pull request
Jul 6, 2026
MaanasArora
pushed a commit
to MaanasArora/numpy
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
*sumand*prodfunctions and correspondingndarraymethods were incorrectly propagating theinteger(and sometimesbool) dtypes of input. But at runtime, these are promoted toint_:This applies to
sum/prodcumsum/cumprodcumulative_sum/cumulative_prodndarray.sum/ndarray.prodndarray.cumsum/ndarray.cumprodma.MaskedArray.cumsum/ma.MaskedArray.cumprodFully written by me (a human, I think); bug found by Claude Fable 5 (high) (here's the full audit for those interested).