Skip to content

DOC: cross-reference np.ma.correlate from np.ma.convolve for propagate_mask - #31852

Merged
mattip merged 2 commits into
numpy:mainfrom
shoumikchakravarty-dev:doc/ma-convolve-examples
Jul 6, 2026
Merged

mattip merged 2 commits into
numpy:mainfrom
shoumikchakravarty-dev:doc/ma-convolve-examples

Conversation

@shoumikchakravarty-dev

Copy link
Copy Markdown
Contributor

PR summary

This is an improvement PR. I have added an Examples section to the documentation for np.ma.convolve showing the propagate_mask behavior (mirroring the existing examples on its sibling np.ma.correlate). Doc-only; doctest-verified locally.

First time committer introduction

No. Previous Contribution #31802

AI Disclosure

An AI assistant (Anthropic's Claude, via the Claude desktop app) was used to locate a public function whose docstring lacked an Examples section, draft the example, and verify it passes as a doctest. I reviewed and understand each line; the change is documentation-only- a new Examples section added to np.ma.convolve. This PR summary and introduction were written by me.

@mattip

mattip commented Jul 6, 2026

Copy link
Copy Markdown
Member

I am not sure we want to bloat the documentation with examples for each use of propogate_mask. Maybe it would be better to add np.ma.correlate to the See Also section with a note "for propogate mask behaviour". Then this PR can be one line.

@shoumikchakravarty-dev shoumikchakravarty-dev changed the title DOC: Added Examples section to np.ma.convolve DOC: cross-reference np.ma.correlate from np.ma.convolve for propagate_mask Jul 6, 2026
@mattip

mattip commented Jul 6, 2026

Copy link
Copy Markdown
Member

Unfortunately you did not use [skip actions] in your commit message, so a full CI run has started.

@shoumikchakravarty-dev

Copy link
Copy Markdown
Contributor Author

@mattip - Thanks. I have dropped the example and instead added the cross reference to np.ma.correlate in the See Also section and updated the PR title to match. Let me know if this looks right.

@mattip
mattip merged commit 0a0bc28 into numpy:main Jul 6, 2026
87 checks passed
@mattip

mattip commented Jul 6, 2026

Copy link
Copy Markdown
Member

Thanks @shoumikchakravarty-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants