Skip to content

TST: add tests for stable ABI numpy extensions - #31822

Merged
kumaraditya303 merged 18 commits into
numpy:mainfrom
kumaraditya303:abi-tests
Jul 6, 2026
Merged

kumaraditya303 merged 18 commits into
numpy:mainfrom
kumaraditya303:abi-tests

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jul 1, 2026 •

Copy link
Copy Markdown
Contributor

PR summary

This PR adds tests for stable ABI extensions compiled with numpy C-API as well as cython API.
limited_api.c is used as a template and parameterized by MODULE_NAME for every combination of Python abi3 version and NumPy target version. Same is done for limited_api_cython where cython extension is tested against every combination of Python abi3 version and NumPy target version. I've expanded tests to cover the datetime APIs which was broken recently to avoid such future breakages.

The failing MSVC test on x86 is because of #31762 which is now detected as a failure.

AI Disclosure

I used Claude to work on this.

@kumaraditya303
kumaraditya303 marked this pull request as ready for review July 1, 2026 10:55
@kumaraditya303

kumaraditya303 commented Jul 1, 2026 •

Copy link
Copy Markdown
Contributor Author

Seems like gcc 9 which is used in the failing old_gcc CI does not support taking address of opaque pointer while de-referencing it. In Limited C-API PyTypeObject is opaque and previously the tests were empty so this was missed, we may need to skip this on such old gcc compilers.

rror: dereferencing pointer to incomplete type ‘PyTypeObject’ {aka ‘struct _typeobject’}
   1156 | #define PyTimedeltaArrType_Type (*(PyTypeObject *)PyArray_API[216])
        |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /opt/hostedtoolcache/Python/3.12.13/x64/include/python3.12/object.h:384:80: note: in definition of macro ‘PyObject_TypeCheck’
    384 | #  define PyObject_TypeCheck(ob, type) PyObject_TypeCheck(_PyObject_CAST(ob), (type))
        |                                                                                ^~~~
  limited_api_cython_3_9_npy2_0.abi3.so.p/limited_api_cython.pyx.c:5078:47: note: in expansion of macro ‘PyTimedeltaArrType_Type’
   5078 |   __pyx_r = PyObject_TypeCheck(__pyx_v_obj, (&PyTimedeltaArrType_Type));
        |                                               ^~~~~~~~~~~~~~~~~~~~~~~

@kumaraditya303
kumaraditya303 requested a review from seberg July 1, 2026 11:01
@seberg
seberg requested a review from ngoldbaum July 1, 2026 11:03
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Jul 1, 2026
@ngoldbaum

Copy link
Copy Markdown
Member

We talked about this at the community meeting and no one objected to dropping gcc9 from the CI matrix. I'm going to put in a PR to do that.

@ngoldbaum ngoldbaum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good. I left some comments inline.

Comment thread numpy/_core/tests/test_limited_api.py Resolved
Comment thread numpy/_core/tests/test_limited_api.py Resolved
Comment thread numpy/_core/tests/test_limited_api.py Resolved
Comment thread numpy/_core/tests/test_limited_api.py Resolved
Comment thread numpy/_core/tests/test_limited_api.py Resolved
@ngoldbaum

Copy link
Copy Markdown
Member

I think if you rebase on or merge with main the error will go away because #31843 is merged.

@ngoldbaum ngoldbaum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did one more review pass and caught a couple minor issues and one suggestion about testing without NPY_TARGET_VERSION that I missed on the last pass. Otherwise I think this looks great so I'm approving. Please go ahead and merge this once you've addressed this last round of comments.

Comment thread numpy/_core/tests/test_limited_api.py Resolved
Comment thread numpy/_core/tests/test_limited_api.py Resolved
@kumaraditya303
kumaraditya303 merged commit afeda72 into numpy:main Jul 6, 2026
85 checks passed
@kumaraditya303
kumaraditya303 deleted the abi-tests branch July 6, 2026 14:10
@charris

charris commented Jul 6, 2026

Copy link
Copy Markdown
Member

Missed the cython version check in meson.build. I'll fix that.

@charris

charris commented Jul 6, 2026

Copy link
Copy Markdown
Member

See #31875.

MaanasArora pushed a commit to MaanasArora/numpy that referenced this pull request Jul 7, 2026
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Jul 7, 2026
charris pushed a commit that referenced this pull request Jul 7, 2026
charris added a commit that referenced this pull request Jul 7, 2026
TST: add tests for stable ABI numpy extensions (#31822)
736-c41-2c1-e464fc974 pushed a commit to Swiss-Armed-Forces/Loom that referenced this pull request Aug 16, 2026
This MR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
| [numpy](https://github.com/numpy/numpy) ([changelog](https://numpy.org/doc/stable/release)) | dependencies | patch | `2.5.0` → `2.5.2` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/numpy/numpy/badge)](https://securityscorecards.dev/viewer/?uri=github.com/numpy/numpy) |
| [uvicorn](https://github.com/Kludex/uvicorn) ([changelog](https://uvicorn.dev/release-notes)) | dependencies | patch | `0.52.1` → `0.52.3` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/Kludex/uvicorn/badge)](https://securityscorecards.dev/viewer/?uri=github.com/Kludex/uvicorn) |

---

### Release Notes

<details>
<summary>numpy/numpy (numpy)</summary>

### [`v2.5.2`](https://github.com/numpy/numpy/releases/tag/v2.5.2): (Aug 9, 2026)

[Compare Source](numpy/numpy@v2.5.1...v2.5.2)

### NumPy 2.5.2 Release Notes

The NumPy 2.5.2 is a patch release that fixes bugs discovered after the 2.5.1
release. The big news is that it includes wheels for the newly released
Python 3.15.0rc1.

This release supports Python versions 3.12-3.15

#### C API changes

##### `PyArray_StringDTypeObject` is opaque under the abi3t stable ABI

The `PyArray_StringDTypeObject` was accidentally exposed in NumPy
2.5 when targeting the free-threading-compatible stable ABI
(`Py_TARGET_ABI3T`). `PyArray_StringDTypeObject` is now an opaque
struct: extensions compiled that way cannot access its fields, since
the struct layout depends on the size of the object header. Any code
that accessed `PyArray_StringDTypeObject` fields in an abi3t build
would have crashed, so we are making this API change in a bugfix
release.

The `NpyString` allocator API remains usable by passing the
descriptor object pointer, e.g.
`NpyString_acquire_allocator((PyArray_StringDTypeObject *)descr)`.

([gh-31771](numpy/numpy#31771))

#### Contributors

A total of 16 people contributed to this release. People with a "+" by their
names contributed a patch for the first time.

- Abhijeetsingh Meena +
- Charalampos Stratakis
- Charles Harris
- Chris Ninham +
- David Woods
- Geonho +
- Gopu Yeshwanth Reddy +
- Iason Krommydas
- Ijtihed Kilani
- Jelle Zijlstra +
- Joren Hammudoglu
- Kumar Aditya
- Mike Boyle
- Nathan Goldbaum
- Raghuveer Devulapalli
- Sebastian Berg

#### Pull requests merged

A total of 28 pull requests were merged for this release.

- [#&#8203;31864](numpy/numpy#31864): MAINT: Prepare 2.5.x for further development
- [#&#8203;31889](numpy/numpy#31889): TYP: Backport multiple static typing fixes 1.
- [#&#8203;31900](numpy/numpy#31900): TST: add tests for stable ABI numpy extensions ([#&#8203;31822](numpy/numpy#31822))
- [#&#8203;31901](numpy/numpy#31901): BUG: fix `StringDType` coerce flag in binary ufunc promotion...
- [#&#8203;31902](numpy/numpy#31902): BLD: fix meson deprecation warnings ([#&#8203;31892](numpy/numpy#31892))
- [#&#8203;31921](numpy/numpy#31921): TYP: Backport multiple typing fixes 2.
- [#&#8203;31947](numpy/numpy#31947): MAINT: Update x86-simd-sort subproject ([`5adb334`](numpy/numpy@5adb334) → [`fa944ef`](numpy/numpy@fa944ef)) ([#&#8203;31908](numpy/numpy#31908))
- [#&#8203;31949](numpy/numpy#31949): BUG: fix crash on 32 bit systems using abi3t ([#&#8203;31771](numpy/numpy#31771))
- [#&#8203;31950](numpy/numpy#31950): MNT: remove some obsolete string to bool workarounds ([#&#8203;31859](numpy/numpy#31859))
- [#&#8203;31952](numpy/numpy#31952): BUG: centralized helper for output coerce and na\_object in stringdtype...
- [#&#8203;31953](numpy/numpy#31953): BUG: fix CPU feature env diagnostic buffer overruns ([#&#8203;31905](numpy/numpy#31905))
- [#&#8203;31954](numpy/numpy#31954): BUG: restore ndarray.conjugate() for legacy user-defined dtypes...
- [#&#8203;31955](numpy/numpy#31955): TYP: Avoid shadowed dtype annotations
- [#&#8203;32077](numpy/numpy#32077): MAINT: Update verdored-meson/meson to match main.
- [#&#8203;32114](numpy/numpy#32114): BUG: fix refcount leak on overlapping copyto with where=False
- [#&#8203;32115](numpy/numpy#32115): BUG: fix swallowed cast error in fancy indexing assignment ([#&#8203;31975](numpy/numpy#31975))
- [#&#8203;32116](numpy/numpy#32116): BUG: Fix buffered iterator stride after removing multi-index
- [#&#8203;32117](numpy/numpy#32117): BUG: fix `np.fromiter` corruption when reusing a `StringDType`...
- [#&#8203;32119](numpy/numpy#32119): BUG: add a special case for StringDType in np.isdtype ([#&#8203;32030](numpy/numpy#32030))
- [#&#8203;32121](numpy/numpy#32121): BUG: reference leak in `simd_sequence_from_iterable` ([#&#8203;32038](numpy/numpy#32038))
- [#&#8203;32122](numpy/numpy#32122): BUG: ensure lock is held when accessing or writing to RNG state...
- [#&#8203;32123](numpy/numpy#32123): BUG: fully reset cached RNG state for non-MT19937 RNGs ([#&#8203;32062](numpy/numpy#32062))
- [#&#8203;32135](numpy/numpy#32135): TYP: type capabilities max dimensions
- [#&#8203;32158](numpy/numpy#32158): BUG: avoid possible stack overflow in arraydescr\_dealloc ([#&#8203;32133](numpy/numpy#32133))
- [#&#8203;32206](numpy/numpy#32206): MAINT: Update cibuildwheel to v4.2.0
- [#&#8203;32214](numpy/numpy#32214): MAINT: Skip limited\_api tests on some platforms.
- [#&#8203;32220](numpy/numpy#32220): TYP: `isclose` shape-typing fix for 2d array-likes ([#&#8203;32205](numpy/numpy#32205))
- [#&#8203;32221](numpy/numpy#32221): BUG: avoid segfaults when legacy copyswap slot is not defined...

### [`v2.5.1`](https://github.com/numpy/numpy/releases/tag/v2.5.1): (July 4, 2026)

[Compare Source](numpy/numpy@v2.5.0...v2.5.1)

### NumPy 2.5.1 Release Notes

The NumPy 2.5.1 is a patch release that fixes bugs discovered after the 2.5.0
release. The most noticeable is the fix is to the numpy datetime cython API
which should allow downstream to support NumPy versions older than 2.5.
Preparation for Python 3.15 continues along with typing improvements.

This release supports Python versions 3.12-3.14

#### Changes

- The minimum supported GCC version has been updated from 9.3.0 to 10.3.0

  ([gh-31843](numpy/numpy#31843))

#### Contributors

A total of 10 people contributed to this release. People with a "+" by their
names contributed a patch for the first time.

- Adhyan Gupta +
- Ankit Ahlawat
- Charles Harris
- Iason Krommydas
- Joren Hammudoglu
- Kumar Aditya
- Nathan Goldbaum
- Sebastian Berg
- Ties Jan Hefting +
- Vineet Kumar

#### Pull requests merged

A total of 20 pull requests were merged for this release.

- [#&#8203;31707](numpy/numpy#31707): MAINT: Prepare 2.5.x for further development
- [#&#8203;31721](numpy/numpy#31721): CI: fix new `cython-lint` errors ([#&#8203;31711](numpy/numpy#31711))
- [#&#8203;31723](numpy/numpy#31723): MAINT: Update meson to match main
- [#&#8203;31729](numpy/numpy#31729): TST: use setup-sde instead of curl to get SDE binaries ([#&#8203;31727](numpy/numpy#31727))
- [#&#8203;31829](numpy/numpy#31829): BUG: Relax finfo to be easier accessible for all user dtypes...
- [#&#8203;31831](numpy/numpy#31831): TYP: Fix `flatiter.__next__` return type for `object_` and...
- [#&#8203;31832](numpy/numpy#31832): BUG: avoid deadlocks using NpyString API ([#&#8203;31682](numpy/numpy#31682))
- [#&#8203;31833](numpy/numpy#31833): BUG: fix out array leak in reduceat and accumulate when dtype...
- [#&#8203;31835](numpy/numpy#31835): BUG: fix numpy datetime cython APIs to be compatible with older...
- [#&#8203;31836](numpy/numpy#31836): TYP: Fix incorrect dtype inference of `asarray([])` ([#&#8203;31732](numpy/numpy#31732))
- [#&#8203;31837](numpy/numpy#31837): TYP: Fix `np.ma.masked_array` 2.5.0 regression
- [#&#8203;31838](numpy/numpy#31838): FIX: Refactor error handling in array\_setstate to prevent typecode...
- [#&#8203;31839](numpy/numpy#31839): TST: xfail multithreaded BLAS test more generously
- [#&#8203;31840](numpy/numpy#31840): MAINT: Rename subroutine for crackfortran tests
- [#&#8203;31842](numpy/numpy#31842): BUG: fix leak in reductions when a ufunc override errors or is...
- [#&#8203;31849](numpy/numpy#31849): BLD: set minimum required gcc version to 10.3 ([#&#8203;31843](numpy/numpy#31843))
- [#&#8203;31855](numpy/numpy#31855): CI: fix hangs on MacOS ASan CI ([#&#8203;31853](numpy/numpy#31853))
- [#&#8203;31856](numpy/numpy#31856): BUG: fix several bugs in StringDType operations ([#&#8203;31846](numpy/numpy#31846))
- [#&#8203;31857](numpy/numpy#31857): BUG: Fix segfault in MT19937 by preventing recursive seed lists...
- [#&#8203;31858](numpy/numpy#31858): BUG: Fix signed integer overflow in datetime.c ([#&#8203;31688](numpy/numpy#31688))

</details>

<details>
<summary>Kludex/uvicorn (uvicorn)</summary>

### [`v0.52.3`](https://github.com/Kludex/uvicorn/releases/tag/0.52.3): Version 0.52.3

[Compare Source](Kludex/uvicorn@0.52.2...0.52.3)

##### Changed

- Update `zttp` to 0.0.24 and use its combined receive path, improving HTTP/1.1 request parsing performance ([#&#8203;3067](Kludex/uvicorn#3067))

**Full Changelog**: <Kludex/uvicorn@0.52.2...0.52.3>

### [`v0.52.2`](https://github.com/Kludex/uvicorn/releases/tag/0.52.2): Version 0.52.2

[Compare Source](Kludex/uvicorn@0.52.1...0.52.2)

##### Fixed

- Update `zttp` to 0.0.22, fixing bodyless request receives and improving HTTP/1 request parsing performance ([#&#8203;3063](Kludex/uvicorn#3063))

**Full Changelog**: <Kludex/uvicorn@0.52.1...0.52.2>

</details>

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTEuMyIsInVwZGF0ZWRJblZlciI6IjQ0LjMwLjQiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyIsInJlbm92YXRlIl19-->

See merge request swiss-armed-forces/cyber-command/cea/loom!639

Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants