Repository navigation
BUG: fix numpy datetime API to be compatible with older versions - #31821
Merged
Merged
Conversation
seberg
approved these changes
Jul 1, 2026
Member
There was a problem hiding this comment.
These diverging is clearly wrong, so LGTM, thanks for the quick fix!
This must be follow up with the API names/general cleanup before we release Python 3.15 wheels, though.
If you want to do this here, happy as well, otherwise please go ahead and just self-merge if you like.
seberg
added
00 - Bug
09 - Backport-Candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #31814
This PR fixes the pandas crash because cython definitons were using symbols which are only present on numpy 2.5 or above. This PR adds fallback just like other macros to directly access the fields on non-opaque so that it is compatible with numpy 2.4 or older.
AI Disclosure
None used.