Repository navigation
BUG: Fix memory leak in _convert_from_type for custom scalar types - #31750
Merged
Merged
Conversation
shipitdev
reviewed
Jun 25, 2026
shipitdev
left a comment
shipitdev
left a comment
Contributor
There was a problem hiding this comment.
The Py_DECREF addition here now properly handles the leaked reference.
Congrats on your first PR here :) welcome to NumPy! This LGTM.
kumaraditya303
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR is from issue #31676 addressing a memory leakage in descriptor.c at line 1598 to 1604 and I have checked and hit all guidlines to the best of my knowledgeFirst time committer introduction
I am michael cogan I am a physics student I have used numpy numerously throughout research and classes I chose this fix because I am trying to build up my resume and also thought it would be cool to help open source and I believed this was an easy enough fix for me to tackle as my first commitAI Disclosure
I used Gemini pro to help me with understanding the scope of the file and I used to run personal tests to make sure the memory leak was fixed all code entered is mine