Repository navigation
TST: Don't run test_tuple_recursion on MacOS - #31740
Merged
Merged
Conversation
This test was always a bit flaky, then it seemed to segfault on x86 Mac, but it seems it segfaults more generally on Mac now. As the comment mentions, best we can tell right now this seems to be a Python issue (whether serious or not) in that we should be entering recursion and Python wants to protect things but doesn't. I can reproduce this locally on a non x86 Mac, although not if I just run the test itself in a small test on it's own...
Member
|
The sanitizer build failure is an unrelated hang during the Python build. Github actions has been a little bit flaky today and I'll chalk this up to that. Merging this. This should not be backported, this is fixing an issue that only happens on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was always a bit flaky, then it seemed to segfault on x86 Mac, but it seems it segfaults more generally on Mac now.
As the comment mentions, best we can tell right now this seems to be a Python issue (whether serious or not) in that we should be entering recursion and Python wants to protect things but doesn't.
I can reproduce this locally on a non x86 Mac, although not if I just run the test itself in a small test on it's own...
Closes gh-31733
(No AI)