Repository navigation
MAINT: Rename subroutine for crackfortran tests - #31726
Merged
Merged
Conversation
The assertion for `bar` not being found in the module path is too broad and can result in a failure if the parent path of the `numpy` package contains `bar`, such as `/nix/store/1234bar5678/numpy-2.4.4`. The subroutines of the test file and the corresponding test has been updated.
tiesjan
changed the title
charris
changed the title
charris
added
03 - Maintenance
09 - Backport-Candidate
Member
|
Thanks @tiesjan . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
When importing
numpyversion 2.4.4 through Nix, its store path (path the package lives in) resulted in/nix/store/r7i744barr4p4vr65110rh4n60w6p93i-python3.14-numpy-2.4.4. This happens to contain the wordbar:...r7i744--bar--r4p4vr.... Unfortunately, this makes one of the tests fail when building the Nix package locally. This is because the test checks forbarin a Fortran module(?) path, since that is a subroutine's name in that Fortran module.By making the subroutine's name more unique, a collision with a Nix store path is less likely to happen.
First time committer introduction
I work as a software engineering lead for @channable and this package is being imported as a dependency as well as for some calculations for our service. The reason for contributing to your project is to ensure the collision with a Nix store path outlined above is less likely to happen again.
AI Disclosure
No AI tools used.