Repository navigation
TST: xfail multithreaded BLAS test more generously - #31714
Merged
Merged
Conversation
mattip
approved these changes
Jun 22, 2026
mattip
left a comment
mattip
left a comment
Member
There was a problem hiding this comment.
LGTM since we don't want this test to generate too much noise.
Member
|
Do you want this backported? The failing IBM problem is unrelated. |
Member
Author
|
Sorry forgot to add the label. This should be backported. |
Member
|
Thanks Nathan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31708.
xfail the test rather than noisily failing when we can't determine the BLAS library, either because we detect the netlib fallback version due to lack of threadpoolctl or because of a wrapper library like flexiblas.
This probably makes the test less useful for detecting buggy BLAS implementations but OpenBLAS is so ubiquitous it's going to be very noisy to make this test fail as often as I had written it originally.