Repository navigation
MAINT: update openblas to 0.3.33.112.0 - #31649
Merged
Merged
Conversation
This was referenced Jun 15, 2026
Member
Author
|
ppc64 and s390x are failing the test_blas_gemm_thread_safety test. |
Member
|
For both the ppc64le and s390x builds: So the test I added probably needs to be xfailed if OpenBLAS is too old. |
ngoldbaum
reviewed
Jun 16, 2026
| if mismatches and _openblas_predates_gemm_fix(blas_name, blas_version): | ||
| pytest.xfail( | ||
| f"OpenBLAS version ({blas_version}) predates first OpenBLAS " | ||
| "version with a fix (0.3.33.112)" |
Member
There was a problem hiding this comment.
this isn't a real upstream version but I can't think of situation where this would be incorrect and where we wouldn't want to know about it
Member
|
Looks like this is working. @mattip is the way I spelled the test skip OK with you? |
Member
Author
|
Ahh right, i dont build those versions of scipy-openblas All good |
Member
Alright, in it goes. Thanks Matti! |
Member
|
@mattip Should this be backported to 2.5.x, or are we good to go there. |
Member
|
This should be backported, IMO |
charris
added
03 - Maintenance
27 - OpenBLAS
08 - Backport
Member
|
I put up #31704 with the backport. If yes, just merge it. |
charris
pushed a commit
that referenced
this pull request
Jun 21, 2026
Co-authored-by: Nathan Goldbaum <[email protected]>
charris
added a commit
that referenced
this pull request
Jun 21, 2026
MAINT: update openblas to 0.3.33.112.0 (#31649)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31618 and maybe #29442
Will need a parallel PR to numpy-release, but I think the CI tests here are more extensive, so the two should be looked at together.