BLD/MAINT: improve support for Intel LLVM compilers#31391
Merged
Conversation
With these changes, downstream users wanting to use the Intel compilers can do so when linking against NumPy headers. Also include a build change for NumPy itself that is clearly correct: Intel compilers do not use `_Fcomplex` & co for complex types, but the regular C99 complex.h types. Taken over from PR 25044 Closes numpygh-25044 Closes numpygh-31337 (reports the same `_Fcomplex` issue) Co-authored-by: Matti Picus <[email protected]>
charris
added
00 - Bug
08 - Backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #31389.
With these changes, downstream users wanting to use the Intel compilers can do so when linking against NumPy headers.
Also include a build change for NumPy itself that is clearly correct: Intel compilers do not use
_Fcomplex& co for complex types, but the regular C99 complex.h types.Taken over from PR gh-25044
Closes gh-25044
Closes gh-31337 (reports the same
_Fcomplexissue)Note: I decided to start fresh because gh-25044 accumulated a conflict, and while most of that PR should no longer be relevant, I didn't want to just push a commit to remove that code. This is the most important and the clearly correct part of that PR, and there's no reason that wasn't merged already.
AI Disclosure
No AI usage