Repository navigation
ENH: Allow user-dtypes return views on .conjugate() - #31264
Merged
Merged
Conversation
This uses the fact that if something _doesn't_ define an imag, then `conjugate()` should be defined as a simple view (similar to `.real`). This is a follow-up of a previous PR, where I didn't implement this isn't really backportable. With this, QuadDType for example does return a view (and a complex new-style dtype can opt out this). This _doesn't_ yet support for `.conjugate()` to return a view for complex numbers (which would make a lot of sense and could be added but take a bit more effort).
SwayamInSync
left a comment
SwayamInSync
left a comment
Member
There was a problem hiding this comment.
LGTM, Thanks @seberg
I agree making the ufunc path also return views might be good work, but at least with this PR user-defined behaviour will be consistent with builtins real types.
Co-authored-by: Swayam <[email protected]>
seberg
commented
Apr 19, 2026
Member
Author
|
Thanks for the reviews. |
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the fact that if something doesn't define an imag, then
conjugate()should be defined as a simple view (similar to.real).This is a follow-up of a previous PR, where I didn't implement this isn't really backportable.
With this, QuadDType for example does return a view (and a complex new-style dtype can opt out this).
This doesn't yet support for
.conjugate()to return a view for complex numbers (which would make a lot of sense and could be added but take a bit more effort).CC @SwayamInSync in case you have time to do the main review maybe, follow up to that other PR (but not backportable, IMO -- I really don't mind adding that
.conj()could be a view eventually).