Repository navigation
DEP: make deprecation visible for __array_wrap__ - #31194
Open
nakul-krishnakumar wants to merge 2 commits into
Open
nakul-krishnakumar wants to merge 2 commits into
nakul-krishnakumar wants to merge 2 commits into
Conversation
Contributor
Author
|
Please let me know if this is the expected change mentioned in this comment. cc: @seberg |
jorenham
added
07 - Deprecation
56 - Needs Release Note.
Contributor
Author
|
@jorenham I have added release notes. |
nakul-krishnakumar
changed the title
__arraywrap____array_wrap__
jorenham
removed
the
56 - Needs Release Note.
Member
|
Thanks, I have opened a bug report on torch: pytorch/pytorch#180657, let's merge after 2.5 is out, probably. |
Member
|
Is xarray affected? I have a vague memory that they used array wrap quite a bit. Also if we still want to do this for 2.6.0, can you please rebase and fix the conflict? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
This PR convert current
DeprecationWarningtoVisibleDeprecationWarningfornumpy.ndarray.__array_wrap__.This PR was made related to this comment.
AI Disclosure
No AI tools used.