Repository navigation
DEP: remove warnings from read_rows - #31113
Merged
Merged
Conversation
Contributor
Author
|
Could you rerun the macOS test please? |
ngoldbaum
reviewed
Apr 3, 2026
ngoldbaum
approved these changes
Apr 4, 2026
Contributor
Author
|
Could someone rerun the failing tests please? Thank you! |
Member
|
No worries, those are just intermediate failures. Agreed, we can just remove this warning, it's been around for a long time. |
Member
|
Thanks @JosephMehdiyev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Partly fixes #30440
Removed a warning from
read_rowsand its related tests.I am not sure if the tests I have removed was only for this case, the match seemed like it was just for this removed warning.
I will open more PRs to close #30440
First time committer introduction
Hey, I am an undergrad maths & stats student at uni of Glasgow. I am starting to contribute PRs to stuff I occasionally use mainly for educational reasons. I like numerical and symbolic methods and computational statistics.
You should be seeing me occasionally in PRs and Discussions from now on here.
AI Disclosure
No AI tools were used in this PR.