Skip to content

MAINT: drop pypy#30764

Merged
jorenham merged 3 commits intonumpy:mainfrom
mattip:drop-pypy
Feb 3, 2026
Merged

MAINT: drop pypy#30764
jorenham merged 3 commits intonumpy:mainfrom
mattip:drop-pypy

Conversation

@mattip
Copy link
Member

@mattip mattip commented Feb 1, 2026

Drop PyPy. Closes #30416

I searched for all PyPy, PYPY, and pypy. Perhaps there are accommodations I missed, like calls to gc.collect(), in tests, that were not marked as needed for PyPy.

Hopefully putting this in one PR will make it possible to revert if PyPy development restarts.

@mattip mattip changed the title drop pypy MAINT: drop pypy Feb 1, 2026
@github-actions

This comment has been minimized.

Sign in to view
@jorenham
Copy link
Member

jorenham commented Feb 2, 2026

Hmm, apparently scipy relies on numpy.testing.IS_PYPY in their tests. Maybe we should keep that one around for a while longer?

@mattip mattip mentioned this pull request Feb 2, 2026
Merged
@mattip
Copy link
Member Author

mattip commented Feb 2, 2026

I restored numpy.testing.IS_PYPY, and submitted scipy/scipy#24491 to detach IS_PYPY. We may want to wait for a SciPy release (or two?) to actually remove IS_PYPY here.

seberg
seberg approved these changes Feb 2, 2026
View reviewed changes
Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matti, LGTM and seems complete. There is nothing else here, right? (I.e. this is ready to just merge? Then go ahead, or I'll do it).

@mattip
Copy link
Member Author

mattip commented Feb 3, 2026

Yes, this is ready to merge from my perspective

@jorenham jorenham merged commit 59f95a3 into numpy:main Feb 3, 2026
79 checks passed
@jorenham
Copy link
Member

jorenham commented Feb 3, 2026

Thanks Matti :)

@ikrommyd ikrommyd mentioned this pull request Feb 3, 2026
Closed
@rgommers
Copy link
Member

rgommers commented Feb 6, 2026

We may want to wait for a SciPy release (or two?) to actually remove IS_PYPY here.

That's the absolute minimum, but more importantly: this should now be considered public API, and break_cycles as well. The problem is from ._private.utils import * in numpy/testing/__init__.py, which leaks things that I don't think we intended to leak.

sabasiddique1 pushed a commit to sabasiddique1/numpy that referenced this pull request Feb 15, 2026
@mattip @sabasiddique1
MAINT: drop pypy (numpy#30764)
e32f06a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seberg seberg seberg approved these changes

Assignees

No one assigned

Labels

03 - Maintenance 24 - PyPy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MAINT: drop support for PyPy

4 participants

@mattip @jorenham @rgommers @seberg