MAINT: undo change to fromstring text signature for 2.4.0
#30235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a very small part of numpygh-30147, because it broken Pythran (see pythran#2368). While a new Pythran 0.18.1 release is available, that doesn't help for the SciPy 1.15.x releases which allow numpy<2.5 and pythran<0.18, see https://github.com/scipy/scipy/blob/maintenance/1.15.x/pyproject.toml#L30-L41 So introducing this signature change only for 2.5.0 is much better. In addition, doing so doesn't leave us only a very narrow window with compatible NumPy and Pythran releases which would otherwise bite distro packagers as well.
jorenham
approved these changes
Nov 16, 2025
Member
|
Yea good call, thanks Ralf. |
Contributor
|
Sorry about that :-/ |
Member
Author
|
No need to be sorry Serge, getting this fixed in Pythran within a week so that we can reintroduce the signature update in 2.5.0 was very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a very small part of gh-30147, because it broke Pythran (see pythran#2368). While a new Pythran 0.18.1 release is available, that doesn't help for the SciPy 1.15.x releases which allow numpy<2.5 and pythran<0.18, see
https://github.com/scipy/scipy/blob/maintenance/1.15.x/pyproject.toml#L30-L41. So introducing this signature change only for 2.5.0 is much better, to avoid breaking SciPy 1.15.x for all users who need to build from source.
In addition, doing so doesn't leave us only a very narrow window with compatible NumPy and Pythran releases which would otherwise bite distro packagers as well.
We can reintroduce this change in
mainin a few weeks, after 2.4.x has branched.Cc @serge-sans-paille @jorenham @charris for visibility.