Skip to content

TYP: fix an invalid default value for array's ndmax parameter - #30160

Merged
mattip merged 1 commit into
numpy:mainfrom
neutrinoceros:typ/array-ndmax-default
Nov 6, 2025
Merged

TYP: fix an invalid default value for array's ndmax parameter#30160
mattip merged 1 commit into
numpy:mainfrom
neutrinoceros:typ/array-ndmax-default

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

fix gh-30159

@neutrinoceros neutrinoceros mentioned this pull request Nov 6, 2025
Merged
1 task
@neutrinoceros
neutrinoceros force-pushed the typ/array-ndmax-default branch from 06722d6 to bd07ad1 Compare November 6, 2025 06:51
@neutrinoceros neutrinoceros changed the title TYP: fix an invalid default value for np.array's ndmax argument TYP: fix an invalid default value for array's ndmax parameter Nov 6, 2025
@neutrinoceros
neutrinoceros force-pushed the typ/array-ndmax-default branch from bd07ad1 to 79403cd Compare November 6, 2025 06:55
@neutrinoceros
neutrinoceros marked this pull request as ready for review November 6, 2025 07:38
@neutrinoceros

neutrinoceros commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

The failure I got on macOS seems unrelated and flaky; I was able to reproduce it locally but only after a handful of attempts.

@neutrinoceros

neutrinoceros commented Nov 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Although a different warning, I wonder if it might stem out of the same bug than gh-29820, which already as an in-PR fix.

FAILED numpy/linalg/tests/test_linalg.py::TestQR::test_stacked_inputs[float32-outer_size2-size1] - RuntimeWarning: invalid value encountered in matmul

Happy to report this independently if needed.

@mattip

mattip commented Nov 6, 2025

Copy link
Copy Markdown
Member

Ahh, I saw the same TestQR::test_stacked_inputs[float32-outer_size2-size1] failure in another CI job, then rerunning it cleared the error. It seems we have not yet ironed out all the Accelerate problems. I wonder what changed lately that could affect this. We updated OpenBLAS but this is using Accelerate.

@neutrinoceros

neutrinoceros commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

Since I can reproduce locally I should be able to bisect this. Does it deserve its own issue ?

@mattip

mattip commented Nov 6, 2025

Copy link
Copy Markdown
Member

Sure that would be great

@neutrinoceros neutrinoceros mentioned this pull request Nov 6, 2025
Closed
@neutrinoceros

neutrinoceros commented Nov 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

gh-30162 👀

@jorenham
jorenham self-requested a review November 6, 2025 10:13
jorenham
jorenham reviewed Nov 6, 2025
View reviewed changes

@jorenham jorenham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It seems a bit weird at first, but the added explanation in the docstring makes sense.

Could you also update the default in _core/multiarray.pyi?

@neutrinoceros
neutrinoceros force-pushed the typ/array-ndmax-default branch from 79403cd to a90a342 Compare November 6, 2025 10:22
@neutrinoceros

neutrinoceros commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

you got it

@mattip
mattip merged commit 83a9fb4 into numpy:main Nov 6, 2025
2 checks passed
@mattip

mattip commented Nov 6, 2025

Copy link
Copy Markdown
Member

Thanks @neutrinoceros

@neutrinoceros
neutrinoceros deleted the typ/array-ndmax-default branch November 6, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorenham jorenham jorenham approved these changes

Assignees

No one assigned

Labels

41 - Static typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TYP: invalid default value documented on array's ndmax parameter

3 participants

@neutrinoceros @mattip @jorenham