MAINT,BUG: make later arguments in array2string keyword only. #30139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
approved these changes
Nov 4, 2025
Member
jorenham
left a comment
jorenham
left a comment
There was a problem hiding this comment.
Apart from one nit this is looking good AFAIK
Comment on lines
+7
to
+8
| This argument had no effect since Numpy 1.14.0. Any arguments following | ||
| it, such as ``formatter`` have now been made keyword-only. |
Member
There was a problem hiding this comment.
Suggested change
| This argument had no effect since Numpy 1.14.0. Any arguments following | |
| it, such as ``formatter`` have now been made keyword-only. | |
| This argument had no effect since Numpy 1.14.0. The parameters following | |
| it, such as ``formatter``, have now been made keyword-only. |
Contributor
Author
There was a problem hiding this comment.
In principle happy to change, but it is called *args, **kwargs, so I'm confused why one would write parameter instead of argument (even if "argument" maybe applies to what we are having -- a friendly one -- rather than computer code...).
Member
There was a problem hiding this comment.
Well, basically, an argument is what you pass a parameter. So the parameter is how you define it, and the argument is how you use it.
Merged
1 task
Member
|
Thanks Marten. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30068, the deprecated
styleargument fromarray2stringwas removed. With that, however, all following arguments shift one up if used as positional arguments. This seems highly undesirable, as any code that used those positional arguments will now fail.The only solution would seem to be to make those later arguments keyword-only -- which this PR does.
p.s. It seems highly unlikely that all positional arguments were used in the wild, but our code in astropy that implements
__array_function__did, and broke by #30068. We don't mind adjusting, but it seemed better to just fix the problem here.