BLD: update scipy-openblas, use -Dpkg_config_path #30049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
commented
Oct 22, 2025
| python -c"import scipy_openblas32 as ob32; print(ob32.get_pkg_config())" > ./.openblas/scipy-openblas.pc | ||
| echo "PKG_CONFIG_PATH=${{ github.workspace }}/.openblas" >> $GITHUB_ENV | ||
| ld_library_path=$(python -c"import scipy_openblas32 as ob32; print(ob32.get_lib_dir())") | ||
| echo "LD_LIBRARY_PATH=$ld_library_path" >> $GITHUB_ENV |
Member
Author
There was a problem hiding this comment.
Not sure why we have LD_LIBRARY_PATH here, leftover cruft?
Member
There was a problem hiding this comment.
Yes, leftover I believe, it was needed once upon a time.
Member
Author
|
Exploring the crash on macos-x86_64 over at MacPython/openblas-libs#219. Any macos compilation experts are welcome to chime in there what might be wrong. |
rgommers
reviewed
Oct 26, 2025
| TERM: xterm-256color | ||
| run: | ||
| spin build -- --werror -Dallow-noblas=false | ||
| spin build -- --werror -Dallow-noblas=false -Dpkg_config_path=${PWD}/.openblas |
1 task
Member
Author
|
The build to watch is "Wheel builder / Build wheel cp311-macosx_x86_64-openblas" which failed with the previous scipy_openblas wheel. |
Member
Author
|
The ubuntu_ubisan CI run seems flaky, I see occasional failures elsewhere. |
mattip
commented
Oct 30, 2025
| spin==0.15 | ||
| # Keep this in sync with ci_requirements.txt | ||
| scipy-openblas32==0.3.30.0.1 | ||
| scipy-openblas32==0.3.30.0.6 |
Member
Author
There was a problem hiding this comment.
Note this does not change the base OpenBLAS commit used, only patches out the not-quite-ready code. OpenBLAS HEAD has also reverted that change, so the patch will not be needed for OpenBLAS 0.3.31. That is why the version here only changes the build from 1 to 6.
Member
|
The issue you mentioned above (MacPython/openblas-libs#219) is still open - are you happy for this to go in now? |
Member
Author
Yes. PR MacPython/openblas-libs#225 fixed MacPython/openblas-libs#219, as "proven" in the passing "Build wheel cp311-macosx_x86_64-openblas" CI run here so I closed that issue. |
Member
|
Recording the unrelated ASan failure for posterity: Details |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Nov 3, 2025
charris
added a commit
that referenced
this pull request
Nov 3, 2025
BLD: update scipy-openblas, use -Dpkg_config_path (#30049)
cakedev0
pushed a commit
to cakedev0/numpy
that referenced
this pull request
Dec 5, 2025
IndifferentArea
pushed a commit
to IndifferentArea/numpy
that referenced
this pull request
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29391 by patching OpenBLAS. Hopefully by the time 0.3.31 is released we can remove the patch.
Also use
spin build -- -Dpkg_config_path=instead of settingPKG_CONFIG_PATHin the normal (non-wheel building) CI.