TYP: Various typing updates #30041
Merged
TYP: Various typing updates #30041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I don't think we should backport |
This comment has been minimized.
This comment has been minimized.
jorenham
reviewed
Oct 21, 2025
jorenham
reviewed
Oct 21, 2025
jorenham
reviewed
Oct 21, 2025
charris
force-pushed
the
typing-updates
branch
from
6d0b573 to
d76fa43
Compare
Co-authored-by: Joren Hammudoglu <[email protected]>
Co-authored-by: Joren Hammudoglu <[email protected]>
Member
Author
|
I am afraid your pushes got lost (again). |
Member
|
The mypy failures in But the mypy failure in Lines 5453 to 5455 in 49e4e89 so that it's something like this: class flexible(_RealMixin, generic[_FlexibleItemT_co], Generic[_FlexibleItemT_co]): ... # type: ignore[misc] |
Member
I did not push anything though |
This comment has been minimized.
This comment has been minimized.
Member
|
The pyspark primer diff originates from this line: tmp_val = arg[np._NoValue] # type: ignore[attr-defined]where arg is a So the previous |
- Update numpy/__init__.pyi - Update numpy/_core/numerictypes.pyi
jorenham
reviewed
Oct 21, 2025
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Joren Hammudoglu <[email protected]>
Member
With this the last two failures should be taken care of |
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on type check results on a corpus of open source code: xarray (https://github.com/pydata/xarray)
+ xarray/compat/npcompat.py: note: In function "isdtype":
+ xarray/compat/npcompat.py:54: error: All conditional function variants must have identical signatures [misc]
+ xarray/compat/npcompat.py:54: note: Original:
+ xarray/compat/npcompat.py:54: note: def isdtype(dtype: dtype[Any] | type, kind: type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None | tuple[type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None, ...]) -> bool
+ xarray/compat/npcompat.py:54: note: Redefinition:
+ xarray/compat/npcompat.py:54: note: def isdtype(dtype: dtype[Any] | type[Any], kind: type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None | tuple[type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None, ...]) -> bool
- xarray/namedarray/dtypes.py: note: In function "maybe_promote":
- xarray/namedarray/dtypes.py:86: error: Too many arguments for "generic" [call-arg]
spark (https://github.com/apache/spark)
+ python/pyspark/pandas/series.py:1210: error: Unused "type: ignore" comment [unused-ignore]
+ python/pyspark/pandas/series.py:1210: error: No overload variant of "__getitem__" of "Series" matches argument type "_NoValueType" [call-overload]
+ python/pyspark/pandas/series.py:1210: note: Error code "call-overload" not covered by "type: ignore" comment
+ python/pyspark/pandas/series.py:1210: note: Possible overload variants:
+ python/pyspark/pandas/series.py:1210: note: def __getitem__(self, list[str] | Index[Any] | Series[Any] | slice[Any, Any, Any] | Series[builtins.bool] | ndarray[tuple[Any, ...], dtype[numpy.bool[builtins.bool]]] | list[builtins.bool] | tuple[Hashable | slice[Any, Any, Any], ...], /) -> Series[Any]
+ python/pyspark/pandas/series.py:1210: note: def __getitem__(self, str | bytes | date | datetime | timedelta | <7 more items> | complex | integer[Any] | floating[Any] | complexfloating[Any, Any], /) -> Any
+ python/pyspark/pandas/series.py:1212: error: Unused "type: ignore" comment [unused-ignore]
|
jorenham
approved these changes
Oct 21, 2025
Member
jorenham
left a comment
jorenham
left a comment
There was a problem hiding this comment.
I went over it again, and I think it should be good to merge now.
Member
|
Thanks @charris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.