MAINT: remove deprecated in numpy/lib/_function_base_impl.py #29997
Conversation
…of` args in `corrcoef` This commit removes long-deprecated code paths in `numpy/lib/_function_base_impl`: - Removed `numpy.trapz`, deprecated in NumPy 2.0 (2023-08-18) - Removed `disp` method - Removed `bias` and `ddof` arguments from `numpy.corrcoef` Removed associated tests from `numpy/lib/tests/test_function_base.py` and `numpy/_core/test_deprecations.py` Associated tests and type stubs were also updated. All tests and Ruff checks pass locally.
|
LGTM. Please add a release note like the one for 29986 but with this PR's number |
mattip
added
the
56 - Needs Release Note.
…rcoef` Removes leftover deprecation logic for the `bias` and `ddof` arguments in `numpy.corrcoef` from `extra.py`. These arguments were already deprecated and removed from `_function_base_impl`. No functional changes beyond removing redundant code. All tests and Ruff checks pass locally.
…from `numpy.ma.extras` and updates the related tests. In addition: - Removed redundant declarations of `bias` and `ddof` in `extras.py` (deprecated since NumPy 2.0) - Removed associated tests from `test_extras.py` and `test_regression.py` - Amended `numpy/lib/_function_base_impl.py` to fully remove these arguments from function signatures and ensure consistency with documentation - Documented the above changes in the release notes All tests and Ruff checks pass locally.
Abhi210
force-pushed
the
gh-11521-remove-deprecations
branch
from
6b39500 to
7065a9d
Compare
|
Hello! I found that there were still some redundant declarations of the Lastly, I’ve updated the release notes as suggested by @jorenham. Thank you for bringing these issues to my attention, and I apologize for the earlier oversight. |
Co-authored-by: Joren Hammudoglu <[email protected]>
…rcoef` Removes leftover deprecation logic for the `bias` and `ddof` arguments in `numpy.corrcoef` from `extra.py`. These arguments were already deprecated and removed from `_function_base_impl`. No functional changes beyond removing redundant code. All tests and Ruff checks pass locally.
|
The previous commit passed all but documentation builds, and the last commit fixed (hoepfully) only documentation problems. I don't think it is worth more iterations on the release note, anyway the release manager can (and sometime does) edit the generated notes before publishing them. |
|
Thanks @Abhi210 |
3 participants
This PR is related to gh-11521 and removes long-deprecated code paths in
numpy/lib/_function_base_impl:numpy.trapz, deprecated in NumPy 2.0 (2023-08-18)dispmethodbiasandddofarguments fromnumpy.corrcoef.numpy/lib/tests/test_function_base.pyandnumpy/_core/test_deprecations.pyAssociated tests and type stubs were also updated. All tests and Ruff checks pass locally.