TYP: missing parameter default in reshape for newshape
#29990
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
Oct 16, 2025
Member
seberg
left a comment
seberg
left a comment
There was a problem hiding this comment.
LGTM, but we have a 1-year minimum policy normally. And that would make this OK to finalize. Considering that I think passing newshape= is very niche, we could also go with that.
Member
Author
Ah nice, let's get rid of it then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stubtest was complaining here, but I'm guessing that It's a bit too early to remove it, so II figured that we might as well annotate it correctly for the time being.