Skip to content

Conversation

@jorenham
Copy link
Member

@jorenham jorenham commented Oct 15, 2025

  • corrcoef: wrong parameter name
  • diff: default argument not assignable to parameter type
  • percentile and quantile: missing (deprecated) interpolation kwarg
  • piecewise: the first three parameters shouldn't be positional-only
  • trim_zeros: missing axis parameter (since 2.2.0)

@jorenham jorenham added 09 - Backport-Candidate PRs tagged should be backported 41 - Static typing labels Oct 15, 2025
@mattip
Copy link
Member

mattip commented Oct 15, 2025

interpolation as a kwarg was deprecated in 1.2. Perhaps it is time to expire the deprecation instead of adding it to typing

@jorenham
Copy link
Member Author

interpolation as a kwarg was deprecated in 1.2. Perhaps it is time to expire the deprecation instead of adding it to typing

Yea seems like the way to go; I'll get on that then.

@mattip mattip merged commit ca76f3b into numpy:main Oct 16, 2025
78 checks passed
@mattip
Copy link
Member

mattip commented Oct 16, 2025

Thanks @jorenham

@jorenham jorenham deleted the typing/_function_base_impl-fixes branch October 16, 2025 05:51
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants