DEP: finalize deprecation of numpy/fft.helpers and numpy.linalg.linalg (closes #28983) #29909
Conversation
|
I'm only seeing a release note. Did you forget to push the deletions? |
|
sorry ... I think there is an issue edit : Please check now |
|
The .pyi also have to be removed |
|
now check |
jorenham
left a comment
jorenham
left a comment
There was a problem hiding this comment.
in numpy/linalg/__init__.pyi there's still a re-export of .linalg that should go
|
ok I have removed init.pyi from both linalg and helpers |
|
Ehh, the
|
|
I have restored the fft/init.pyi and updated the linalg/init.pyi please check .. and if further enhancements required there please infrom me . |
| Previously deprecated, use :mod:`numpy.linalg` instead. | ||
|
|
||
| * :mod:`numpy.fft.helpers` | ||
| Previously deprecated, use :mod:`numpy.fft` instead. No newline at end of file |
There was a problem hiding this comment.
This is actually PR 29909, not 29000.
There was a problem hiding this comment.
what I have to do now ?
There was a problem hiding this comment.
$ git mv doc/release/upcoming_changes/29000.expiring.rst doc/release/upcoming_changes/29909.expiring.rst
$ git commit -m"correct release note name"
$ git push
There was a problem hiding this comment.
I have changed ... please check
There was a problem hiding this comment.
Almost. It is PR 29909 not 29009, and the name needs to be expired not expiring
There was a problem hiding this comment.
Pull Request Overview
This PR finalizes the deprecation of two NumPy modules by removing the deprecated shim modules numpy.linalg.linalg and numpy.fft.helpers, replacing them with empty files. The public APIs remain unchanged as all functions are still available through their proper modules (numpy.linalg and numpy.fft).
- Removed deprecated shim modules that were redirecting to private implementations
- Added release notes documenting the removal of these deprecated features
- Updated type stub files to reflect the module removals
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| numpy/linalg/linalg.py | Removed deprecated shim module, replaced with empty file |
| numpy/linalg/linalg.pyi | Removed type stubs for deprecated module |
| numpy/linalg/init.pyi | Removed import reference to deprecated linalg module |
| numpy/fft/helper.py | Removed deprecated shim module, replaced with empty file |
| numpy/fft/helper.pyi | Removed type stubs for deprecated module |
| doc/release/upcoming_changes/29009.expiring.rst | Added release notes documenting the removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
General CI was passing, so I added a commit that I hope fixes doc building while skipping the rest of CI. |
|
thanks @mattip |
|
please merge the pull request |
|
Here is the rendered release note. |
Usually release notes like this one go under the |
|
@jorenham I see it under the Expired section, no? |
Oh woops brainfart |
|
Thanks @anikchand461 |
|
Thanks for merging the PR @mattip |
3 participants
Post-2.0 cleanup: Remove deprecated shims and add release note.
Changes:
numpy/linalg/linalg.pynumpy/fft/helpers.pydoc/release/upcoming/29000.expiring.rst(placeholder; update to PR # post-creation)No breaking changes—public APIs (e.g.,
np.linalg.inv,np.fft.fft) unchanged. CI will verify tests.Bundle per @mattip's guidance in #28983. Closes #28983.