BUG: Fix assert in nditer buffer setup #29780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a buffered iteration, there was a new assert to check that strides were set up nicely to ensure that we are not missing dimension coalescing. However, when the strides are set up to track an index, then they were still set up with a 0 for length 1. I _think_ that is just unnecessary (i.e. the assert is correct to point it out). But, let's do this first for backporting at least. Signed-off-by: Sebastian Berg <[email protected]>
Member
|
Thanks @seberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a buffered iteration, there was a new assert to check that strides were set up nicely to ensure that we are not missing dimension coalescing.
However, when the strides are set up to track an index, then they were still set up with a 0 for length 1.
I think that is just unnecessary (i.e. the assert is correct to point it out). But, let's do this first for backporting at least.
Closes gh-29690