Skip to content

Conversation

@WarrenWeckesser
Copy link
Member

@WarrenWeckesser WarrenWeckesser commented Sep 21, 2025

spin 0.15 pins its click dependency to avoid the newly released click version 8.3.0.

@github-actions github-actions bot added the 36 - Build Build related PR label Sep 21, 2025
@WarrenWeckesser
Copy link
Member Author

WarrenWeckesser commented Sep 21, 2025

The clang_TSAN job from compiler_sanitizers.yml appears to use a container where all the Python packages are pre-installed. I don't know how and when this container is updated, so I'm not sure what is in there. Apparently it gets the newly released click 8.3.0, but it does not have the even newer spin 0.15. I could attempt to hack compiler_sanitizers.yml to upgrade spin before it is used to build numpy (probably right after pytest-xdist is removed), but I don't know if that is the "correct" solution for this job.

Edit: Let's give it a shot...

@charris
Copy link
Member

charris commented Sep 21, 2025

@ngoldbaum I see that you have opened other issues at https://github.com/nascheme/cpython_sanity/pkgs/container/numpy-tsan, seems we need another.

Edit: Let's give it a shot...

We can ignore/disable it for a while.

@ngoldbaum
Copy link
Member

We can ignore/disable it for a while.

Go ahead and disable it, I’ll reenable it later this week with a fix.

@charris
Copy link
Member

charris commented Sep 21, 2025

Looks like @WarrenWeckesser fix works.

@ngoldbaum
Copy link
Member

Yeah that works. The other thing that might be more sustainable is to use the cpython_tsan image and then install numpy’s build nd test dependencies from the requirements file like we do everywhere else. The only difference that numpy_tsan has is that it includes a numpy build and I think whoever added this used that to bootstrap the numpy build environment, but that leads to issues like this.

@charris charris merged commit 84dbaa2 into numpy:main Sep 21, 2025
77 checks passed
@charris
Copy link
Member

charris commented Sep 21, 2025

Let's get this in to fix the CI failures, we can tweak it later. Thanks Warren.

@WarrenWeckesser WarrenWeckesser deleted the spin-upgrade branch September 21, 2025 19:11
@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Sep 22, 2025
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

36 - Build Build related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants