Skip to content

BUG: np.setbufsize should raise ValueError for negative input #29774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattip merged 2 commits into from
Sep 22, 2025
Merged

BUG: np.setbufsize should raise ValueError for negative input #29774

mattip merged 2 commits into from
Sep 22, 2025

Conversation

@cibarbia05
Copy link
Contributor

@cibarbia05 cibarbia05 commented Sep 20, 2025

Closes #29651

This PR fixes an issue where np.setbufsize silently accepted negative
values. Passing a negative value now raises a ValueError with a clear
error message.

Changes

  • Added a check in np.setbufsize to raise ValueError when size < 0.
  • Added a new unit test test_negative_value_raises in
    numpy/_core/tests/test_umath.py.

Example

>>> import numpy as np
>>> np.setbufsize(-5)
Traceback (most recent call last):
    ...
ValueError: buffer size must be non-negative

@cibarbia05
BUG: np.setbufsize should raise ValueError for negative input
a9bbd23 
np.setbufsize previously accepted negative values silently.
This commit adds input validation so that a ValueError is raised
when a negative buffer size is provided, and adds a regression test
to cover this behavior.

Closes numpy#29651
@mattip
Copy link
Member

mattip commented Sep 21, 2025

Something broke the build. I am seeing this in various CI steps that re-use the meson build to run other spin steps

Invoking `build` prior to running tests:
$ /opt/hostedtoolcache/Python/3.11.13/x64/bin/python vendored-meson/meson/meson.py compile -j Sentinel.UNSET -C build

Where is this Sentinel.UNSET coming from? There is a click problem I see elsewhere, something about sentinel values, did we not pin the click version in the requirements?

@WarrenWeckesser
Copy link
Member

WarrenWeckesser commented Sep 21, 2025 •
edited
Loading

The corresponding scipy issue is scipy/scipy#23642.

A solution would be to ensure that spin 0.15 is used. (click is a transitive dependency coming from spin.)

@charris
Copy link
Member

charris commented Sep 21, 2025

close/reopen

@charris charris closed this Sep 21, 2025
@charris charris reopened this Sep 21, 2025
mattip
mattip reviewed Sep 22, 2025
View reviewed changes
@mattip mattip merged commit 435c2cd into numpy:main Sep 22, 2025
77 checks passed
@mattip
Copy link
Member

mattip commented Sep 22, 2025

Thanks @cibarbia05

@cibarbia05
Copy link
Contributor Author

cibarbia05 commented Sep 22, 2025

Thanks @cibarbia05

Thanks for the review and merge! Glad to contribute.

@charris charris added the 09 - Backport-Candidate PRs tagged should be backported label Sep 22, 2025
@charris charris mentioned this pull request Sep 23, 2025
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattip mattip mattip left review comments

Assignees

No one assigned

Labels

00 - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

np.setbufsize accepts negative values silently instead of raising an error

4 participants

@cibarbia05 @mattip @WarrenWeckesser @charris