TYP: Remove None from definition of DTypeLike type alias
#29739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We could do a little experiment and try to see what mypy_primer will report when we remove |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Hmm, I expected worse. It's mostly xarray that's affected by this it seems. |
MarcoGorelli
changed the title
DTypeLike | None fixNone from definition of DTypeLike type alias
MarcoGorelli
changed the title
None from definition of DTypeLike type aliasNone from definition of DTypeLike type alias
Member
Author
|
Yup. And even then, it looks manageable IMHO this would be an acceptable change, but it's your decision of course |
Member
|
Since there's no way to deprecate this, there's no painless way of doing this, so I'm inclined to agree. |
jorenham
reviewed
Sep 12, 2025
Member
jorenham
left a comment
jorenham
left a comment
There was a problem hiding this comment.
there are also some None-less DTypeLike's in _core.numerictypes
Member
Author
|
sure, i've added it to |
Member
|
The |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jorenham
reviewed
Sep 12, 2025
Co-authored-by: Joren Hammudoglu <[email protected]>
This comment has been minimized.
This comment has been minimized.
jorenham
added
the
56 - Needs Release Note.
Member
|
Ok the xarray PR has been merged, so it should be gone from the next mypy_primer run. Also, it's probably a good idea to put this in the release notes. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jorenham
reviewed
Sep 30, 2025
This comment has been minimized.
This comment has been minimized.
jorenham
reviewed
Oct 1, 2025
Co-authored-by: Joren Hammudoglu <[email protected]>
|
Diff from mypy_primer, showing the effect of this PR on type check results on a corpus of open source code: xarray (https://github.com/pydata/xarray)
- xarray/compat/npcompat.py:54: note: def isdtype(dtype: dtype[Any] | type, kind: type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None | tuple[type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None, ...]) -> bool
+ xarray/compat/npcompat.py:54: note: def isdtype(dtype: dtype[Any] | type, kind: type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | tuple[type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str, ...]) -> bool
- xarray/compat/npcompat.py:54: note: def isdtype(dtype: dtype[Any] | type[Any], kind: type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None | tuple[type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None, ...]) -> bool
+ xarray/compat/npcompat.py:54: note: def isdtype(dtype: dtype[Any] | type[Any], kind: type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | tuple[type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str, ...]) -> bool
pandera (https://github.com/pandera-dev/pandera)
- pandera/engines/numpy_engine.py:60: error: Item "_SupportsDType[dtype[Any]]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "type" [union-attr]
+ pandera/engines/numpy_engine.py:60: error: Item "_SupportsDType[dtype[Any]]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "type" [union-attr]
- pandera/engines/numpy_engine.py:60: error: Item "tuple[Any, ...]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "type" [union-attr]
+ pandera/engines/numpy_engine.py:60: error: Item "tuple[Any, ...]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "type" [union-attr]
- pandera/engines/numpy_engine.py:60: error: Item "list[Any]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "type" [union-attr]
+ pandera/engines/numpy_engine.py:60: error: Item "list[Any]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "type" [union-attr]
- pandera/engines/numpy_engine.py:60: error: Item "_DTypeDict" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "type" [union-attr]
+ pandera/engines/numpy_engine.py:60: error: Item "_DTypeDict" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "type" [union-attr]
- pandera/engines/numpy_engine.py:60: error: Item "str" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "type" [union-attr]
+ pandera/engines/numpy_engine.py:60: error: Item "str" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "type" [union-attr]
- pandera/engines/numpy_engine.py:60: error: Item "None" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "type" [union-attr]
- pandera/engines/numpy_engine.py:77: error: Item "_SupportsDType[dtype[Any]]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "name" [union-attr]
+ pandera/engines/numpy_engine.py:77: error: Item "_SupportsDType[dtype[Any]]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "name" [union-attr]
- pandera/engines/numpy_engine.py:77: error: Item "tuple[Any, ...]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "name" [union-attr]
+ pandera/engines/numpy_engine.py:77: error: Item "tuple[Any, ...]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "name" [union-attr]
- pandera/engines/numpy_engine.py:77: error: Item "list[Any]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "name" [union-attr]
+ pandera/engines/numpy_engine.py:77: error: Item "list[Any]" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "name" [union-attr]
- pandera/engines/numpy_engine.py:77: error: Item "_DTypeDict" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "name" [union-attr]
+ pandera/engines/numpy_engine.py:77: error: Item "_DTypeDict" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "name" [union-attr]
- pandera/engines/numpy_engine.py:77: error: Item "str" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "name" [union-attr]
+ pandera/engines/numpy_engine.py:77: error: Item "str" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str" has no attribute "name" [union-attr]
- pandera/engines/numpy_engine.py:77: error: Item "None" of "type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None" has no attribute "name" [union-attr]
spark (https://github.com/apache/spark)
- python/pyspark/pandas/frame.py:11229: error: Argument 1 to "is_bool_dtype" has incompatible type "pyspark.pandas.series.Series[Any]"; expected "ExtensionArray | ndarray[tuple[Any, ...], dtype[Any]] | type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | None | pandas.core.series.Series[Any] | DataFrame | Index[Any] | ExtensionDtype" [arg-type]
+ python/pyspark/pandas/frame.py:11229: error: Argument 1 to "is_bool_dtype" has incompatible type "pyspark.pandas.series.Series[Any]"; expected "ExtensionArray | ndarray[tuple[Any, ...], dtype[Any]] | type[Any] | dtype[Any] | _SupportsDType[dtype[Any]] | tuple[Any, Any] | list[Any] | _DTypeDict | str | pandas.core.series.Series[Any] | DataFrame | Index[Any] | ExtensionDtype" [arg-type]
|
jorenham
approved these changes
Oct 2, 2025
Member
|
In it goes... Thanks Marco; great QOL improvement! |
bwhitt7
pushed a commit
to bwhitt7/numpy
that referenced
this pull request
Oct 4, 2025
…py#29739) Co-authored-by: Joren Hammudoglu <[email protected]>
bwhitt7
pushed a commit
to bwhitt7/numpy
that referenced
this pull request
Oct 7, 2025
…py#29739) Co-authored-by: Joren Hammudoglu <[email protected]>
IndifferentArea
pushed a commit
to IndifferentArea/numpy
that referenced
this pull request
Dec 7, 2025
…py#29739) Co-authored-by: Joren Hammudoglu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #29634 (comment)
I haven't removed
| NonefromDTypeLike, as it's a publicly exported type and so changing it would be a breaking change, and I didn't know if that would be OKNote that there are some places which currently accept
dtype: DTypeLike, even thoughNonecannot be passed. For example,isdtype:numpy/numpy/_core/numerictypes.pyi
Line 157 in 9c29c32
It says
DTypeLike, which includesNone, althoughNoneis not valid at runtimeAnyway, I've left such cases alone