TYP: Add missing defaults to stubs #29634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorenham
reviewed
Aug 30, 2025
…pe in overloads for `norm` functions, document defaults for `int` and `fromroots`, correct `_FloatLike_co | None = None`
Member
Author
|
Thanks for your review! I've addressed the comments OK if I address #29634 (comment) and #29634 (comment) separately? I agree with the suggestion, it just looks orthogonal, and there's already quite a few changes |
This comment has been minimized.
This comment has been minimized.
Member
Yea that's probably better |
MarcoGorelli
force-pushed
the
param-defaults
branch
2 times, most recently
from
c4c8fc3 to
1fdbae5
Compare
Member
|
Thanks Marco |
IndifferentArea
pushed a commit
to IndifferentArea/numpy
that referenced
this pull request
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #28428
applies the (misnamed, as it doesn't use the docs) docs2types script to add defaults in missing places