TYP: Remove MaskedArray.__reduce__, and punt on MaskedArray.__{eq,ne}__
#29470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
typ-ma-reduce
branch
from
1fa4bac to
949d5ee
Compare
MarcoGorelli
commented
Jul 29, 2025
52 tasks
jorenham
reviewed
Jul 30, 2025
Member
jorenham
left a comment
jorenham
left a comment
There was a problem hiding this comment.
AFAIK, it's also fine to just remove the 🥒 methods; they probably won't be used directly, and they're already annotated in object:
MarcoGorelli
changed the title
MaskedArray.__reduce__, and punt on MaskedArray.__{eq,ne}__MaskedArray.__reduce__, and punt on MaskedArray.__{eq,ne}__
jorenham
approved these changes
Jul 30, 2025
IndifferentArea
pushed a commit
to IndifferentArea/numpy
that referenced
this pull request
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.