Skip to content

TYP: Type MaskedArray.__deepcopy__ and MaskedArray.argsort #29418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorenham merged 3 commits into from
Jul 23, 2025
Merged

TYP: Type MaskedArray.__deepcopy__ and MaskedArray.argsort #29418

jorenham merged 3 commits into from
Jul 23, 2025

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jul 22, 2025 •
edited
Loading

order just gets passed down to ndarray.argsort as-is

numpy/numpy/ma/core.py

Lines 5675 to 5695 in 75e86ba

if stable:
raise ValueError(
"`stable` parameter is not supported for masked arrays."
)
# 2017-04-11, Numpy 1.13.0, gh-8701: warn on axis default
if axis is np._NoValue:
axis = _deprecate_argsort_axis(self)
if fill_value is None:
if endwith:
# nan > inf
if np.issubdtype(self.dtype, np.floating):
fill_value = np.nan
else:
fill_value = minimum_fill_value(self)
else:
fill_value = maximum_fill_value(self)
filled = self.filled(fill_value)
return filled.argsort(axis=axis, kind=kind, order=order)

so I've taken the annotation from there and updated the MaskedArray.argsort docstring accordingly

@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 23, 2025 09:46
@jorenham jorenham self-requested a review July 23, 2025 11:27
@jorenham jorenham added the component: numpy.ma masked arrays label Jul 23, 2025
@jorenham jorenham mentioned this pull request Jul 21, 2025
Open
52 tasks
jorenham
jorenham reviewed Jul 23, 2025
View reviewed changes
@jorenham jorenham merged commit 436662e into numpy:main Jul 23, 2025
78 checks passed
@jorenham
Copy link
Member

jorenham commented Jul 23, 2025

Thanks Marco :)

IndifferentArea pushed a commit to IndifferentArea/numpy that referenced this pull request Dec 7, 2025
@MarcoGorelli @IndifferentArea
TYP: Type MaskedArray.__deepcopy__ and MaskedArray.argsort (n…
dc0f332 
…umpy#29418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorenham jorenham jorenham approved these changes

Assignees

No one assigned

Labels

41 - Static typing component: numpy.ma masked arrays

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcoGorelli @jorenham