Skip to content

TYP: Type MaskedArray.{sum,std,var,mean,prod} #29381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorenham merged 6 commits into from
Jul 16, 2025
Merged

TYP: Type MaskedArray.{sum,std,var,mean,prod} #29381

jorenham merged 6 commits into from
Jul 16, 2025
+174 −7

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jul 15, 2025

No description provided.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 15, 2025 12:40
@jorenham jorenham added the component: numpy.ma masked arrays label Jul 15, 2025
@jorenham jorenham self-requested a review July 15, 2025 12:44
@jorenham jorenham mentioned this pull request Jul 15, 2025
Open
52 tasks
jorenham
jorenham requested changes Jul 15, 2025
View reviewed changes
Copy link
Member

@jorenham jorenham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keepdims param defaults to np._NoValue instead of False, and std and var also have a mean=np._NoValue parameter.

update

It's not strange that you missed the mean, because it's missing in ndarray docstring: #29384

@MarcoGorelli MarcoGorelli marked this pull request as draft July 16, 2025 10:53
@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 16, 2025 14:01
@jorenham jorenham merged commit 0fee7d8 into numpy:main Jul 16, 2025
78 checks passed
@jorenham
Copy link
Member

jorenham commented Jul 16, 2025

Thanks Marco

MaanasArora pushed a commit to MaanasArora/numpy that referenced this pull request Jul 16, 2025
@MarcoGorelli @MaanasArora
TYP: Type MaskedArray.{sum,std,var,mean,prod} (numpy#29381)
3991518
IndifferentArea pushed a commit to IndifferentArea/numpy that referenced this pull request Dec 7, 2025
@MarcoGorelli @IndifferentArea
TYP: Type MaskedArray.{sum,std,var,mean,prod} (numpy#29381)
7b28290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorenham jorenham jorenham approved these changes

Assignees

No one assigned

Labels

41 - Static typing component: numpy.ma masked arrays

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcoGorelli @jorenham